On 8/15/2016 11:45 PM, Martin Storsjö wrote:
Remove the extra copyright disclaimer headers that you're adding. If you're keen on adding them, send a separate patch for that.

I have removed the 'extra' text (attached). Note that I am attaching 2 files, but they are identical. The goal is to see if text/x-patch files are being accepted by this list now.

I still think this level of 'purity' results in a great deal of unnecessary work on everyone's part. But if this is what's required to get patches approved...

No other objection from me, but please wait for at least somebody else to comment on it as well.

Are you not authorized to approve patches? Who should I be looking for email from then? Or is there something about this particular patch that requires a closer look?

dw
diff --git a/mingw-w64-crt/complex/clog10.c b/mingw-w64-crt/complex/clog10.c
index f8545cd..8553e00 100644
--- a/mingw-w64-crt/complex/clog10.c
+++ b/mingw-w64-crt/complex/clog10.c
@@ -44,5 +44,6 @@
 
 /* double version of the functions.  */
 #define  _NEW_COMPLEX_DOUBLE 1
+#define _GNU_SOURCE
 #include "complex_internal.h"
 #include "clog10.def.h"
diff --git a/mingw-w64-crt/complex/clog10f.c b/mingw-w64-crt/complex/clog10f.c
index 36ac497..8ce97d3 100644
--- a/mingw-w64-crt/complex/clog10f.c
+++ b/mingw-w64-crt/complex/clog10f.c
@@ -44,5 +44,6 @@
 
 /* Float version of the functions.  */
 #define  _NEW_COMPLEX_FLOAT 1
+#define _GNU_SOURCE
 #include "complex_internal.h"
 #include "clog10.def.h"
diff --git a/mingw-w64-crt/complex/clog10l.c b/mingw-w64-crt/complex/clog10l.c
index 8baa2aa..11d85c7 100644
--- a/mingw-w64-crt/complex/clog10l.c
+++ b/mingw-w64-crt/complex/clog10l.c
@@ -44,5 +44,6 @@
 
 /* long double version of the functions.  */
 #define  _NEW_COMPLEX_LDOUBLE 1
+#define _GNU_SOURCE
 #include "complex_internal.h"
 #include "clog10.def.h"
diff --git a/mingw-w64-crt/libsrc/ws2tcpip/gai_strerrorA.c b/mingw-w64-crt/libsrc/ws2tcpip/gai_strerrorA.c
index ebdc06a..9023f93 100644
--- a/mingw-w64-crt/libsrc/ws2tcpip/gai_strerrorA.c
+++ b/mingw-w64-crt/libsrc/ws2tcpip/gai_strerrorA.c
@@ -3,6 +3,7 @@
 #endif
 #undef  __CRT__NO_INLINE
 #define __CRT__NO_INLINE
+#include <stdlib.h>
 #include <winsock2.h>
 #include <ws2tcpip.h>
 
diff --git a/mingw-w64-crt/math/abs64.c b/mingw-w64-crt/math/abs64.c
index 693f909..3f2133a 100644
--- a/mingw-w64-crt/math/abs64.c
+++ b/mingw-w64-crt/math/abs64.c
@@ -1,4 +1,5 @@
 #include <intrin.h>
+#include <stdlib.h>
 
 __MINGW_EXTENSION __int64 __cdecl _abs64(__int64 x) {
     return llabs(x);
diff --git a/mingw-w64-crt/secapi/_vscprintf_p.c b/mingw-w64-crt/secapi/_vscprintf_p.c
index 42365b3..7c4ea5b 100644
--- a/mingw-w64-crt/secapi/_vscprintf_p.c
+++ b/mingw-w64-crt/secapi/_vscprintf_p.c
@@ -1,4 +1,5 @@
 #define _vscprintf_p SAVE__vscprintf_p
+#define MINGW_HAS_SECURE_API 1
 #include <stdio.h>
 #undef _vscprintf_p
 
diff --git a/mingw-w64-crt/secapi/_vscwprintf_p.c b/mingw-w64-crt/secapi/_vscwprintf_p.c
index 7baa5bd..e46cf30 100644
--- a/mingw-w64-crt/secapi/_vscwprintf_p.c
+++ b/mingw-w64-crt/secapi/_vscwprintf_p.c
@@ -1,4 +1,5 @@
 #define _vscwprintf_p SAVE__vscwprintf_p
+#define MINGW_HAS_SECURE_API 1
 #include <stdio.h>
 #undef _vscwprintf_p
 
diff --git a/mingw-w64-crt/secapi/_vswprintf_p.c b/mingw-w64-crt/secapi/_vswprintf_p.c
index eb10c59..c94dc7c 100644
--- a/mingw-w64-crt/secapi/_vswprintf_p.c
+++ b/mingw-w64-crt/secapi/_vswprintf_p.c
@@ -1,4 +1,5 @@
 #define _vswprintf_p SAVE__vswprintf_p
+#define MINGW_HAS_SECURE_API 1
 #include <stdio.h>
 #undef _vswprintf_p
 
diff --git a/mingw-w64-crt/complex/clog10.c b/mingw-w64-crt/complex/clog10.c
index f8545cd..8553e00 100644
--- a/mingw-w64-crt/complex/clog10.c
+++ b/mingw-w64-crt/complex/clog10.c
@@ -44,5 +44,6 @@
 
 /* double version of the functions.  */
 #define  _NEW_COMPLEX_DOUBLE 1
+#define _GNU_SOURCE
 #include "complex_internal.h"
 #include "clog10.def.h"
diff --git a/mingw-w64-crt/complex/clog10f.c b/mingw-w64-crt/complex/clog10f.c
index 36ac497..8ce97d3 100644
--- a/mingw-w64-crt/complex/clog10f.c
+++ b/mingw-w64-crt/complex/clog10f.c
@@ -44,5 +44,6 @@
 
 /* Float version of the functions.  */
 #define  _NEW_COMPLEX_FLOAT 1
+#define _GNU_SOURCE
 #include "complex_internal.h"
 #include "clog10.def.h"
diff --git a/mingw-w64-crt/complex/clog10l.c b/mingw-w64-crt/complex/clog10l.c
index 8baa2aa..11d85c7 100644
--- a/mingw-w64-crt/complex/clog10l.c
+++ b/mingw-w64-crt/complex/clog10l.c
@@ -44,5 +44,6 @@
 
 /* long double version of the functions.  */
 #define  _NEW_COMPLEX_LDOUBLE 1
+#define _GNU_SOURCE
 #include "complex_internal.h"
 #include "clog10.def.h"
diff --git a/mingw-w64-crt/libsrc/ws2tcpip/gai_strerrorA.c 
b/mingw-w64-crt/libsrc/ws2tcpip/gai_strerrorA.c
index ebdc06a..9023f93 100644
--- a/mingw-w64-crt/libsrc/ws2tcpip/gai_strerrorA.c
+++ b/mingw-w64-crt/libsrc/ws2tcpip/gai_strerrorA.c
@@ -3,6 +3,7 @@
 #endif
 #undef  __CRT__NO_INLINE
 #define __CRT__NO_INLINE
+#include <stdlib.h>
 #include <winsock2.h>
 #include <ws2tcpip.h>
 
diff --git a/mingw-w64-crt/math/abs64.c b/mingw-w64-crt/math/abs64.c
index 693f909..3f2133a 100644
--- a/mingw-w64-crt/math/abs64.c
+++ b/mingw-w64-crt/math/abs64.c
@@ -1,4 +1,5 @@
 #include <intrin.h>
+#include <stdlib.h>
 
 __MINGW_EXTENSION __int64 __cdecl _abs64(__int64 x) {
     return llabs(x);
diff --git a/mingw-w64-crt/secapi/_vscprintf_p.c 
b/mingw-w64-crt/secapi/_vscprintf_p.c
index 42365b3..7c4ea5b 100644
--- a/mingw-w64-crt/secapi/_vscprintf_p.c
+++ b/mingw-w64-crt/secapi/_vscprintf_p.c
@@ -1,4 +1,5 @@
 #define _vscprintf_p SAVE__vscprintf_p
+#define MINGW_HAS_SECURE_API 1
 #include <stdio.h>
 #undef _vscprintf_p
 
diff --git a/mingw-w64-crt/secapi/_vscwprintf_p.c 
b/mingw-w64-crt/secapi/_vscwprintf_p.c
index 7baa5bd..e46cf30 100644
--- a/mingw-w64-crt/secapi/_vscwprintf_p.c
+++ b/mingw-w64-crt/secapi/_vscwprintf_p.c
@@ -1,4 +1,5 @@
 #define _vscwprintf_p SAVE__vscwprintf_p
+#define MINGW_HAS_SECURE_API 1
 #include <stdio.h>
 #undef _vscwprintf_p
 
diff --git a/mingw-w64-crt/secapi/_vswprintf_p.c 
b/mingw-w64-crt/secapi/_vswprintf_p.c
index eb10c59..c94dc7c 100644
--- a/mingw-w64-crt/secapi/_vswprintf_p.c
+++ b/mingw-w64-crt/secapi/_vswprintf_p.c
@@ -1,4 +1,5 @@
 #define _vswprintf_p SAVE__vswprintf_p
+#define MINGW_HAS_SECURE_API 1
 #include <stdio.h>
 #undef _vswprintf_p
 
------------------------------------------------------------------------------
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to