On Nov 12 14:52, Ray Donnelly wrote: > On Nov 12, 2016 1:30 PM, "Corinna Vinschen" <vinsc...@redhat.com> wrote: > > > > On Nov 12 12:27, JonY wrote: > > > On 11/12/2016 11:57, Mihail Konev wrote: > > > > Applications now could call iscygtty(STDIN_FILENO) > > > > in order to detect whether they are running from > > > > Cygwin/MSys terminal. > > > > > > > > Without that, they have no choice but to think that > > > > stdin is redirected from a named pipe. > > > > > > > > Signed-off-by: Mihail Konev <k....@ya.ru> > > > > Moved-from: https://github.com/Alexpux/mingw-w64/pull/3 > > > > > > I don't really have any big objections other than on style. > > > > 1. This should be *strictly* non-Cygwin/non-MSYS. Only native Windows > > applications will have a problem to recognize Cygwin ptys, thus this > > functions makes no sense at all for applications linked against > > Cygwin or MSYS. > > > > 2. Why include a non-standard API? Why not provide this as isatty > > function as a replacement for the system isatty? I'd wager your > > boots on this function going mostly unused, otherwise. > > MSYS2 will use it extensively.
If MSYS2 uses it there's something wrong. MSYS2 is Cygwin, so it doesn't need this function at all; It has everything already builtin. Again: Only non-Cygwin applications will need this function. Corinna
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi
_______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
