在 2020/4/5 3:52, Martin Storsjö 写道: > > In this case - I hadn't expected you to verify it before pushing, I had > expected the patch author to try to use it - but if you do such checks > before pushing, it's really commendable! > > In this case, it turns out that it didn't pick up the issue, because > windows.h in itself also includes memoryapi.h, and it will include > windows.h from your compiler's default sysroot, and that one will > transitively include memoryapi.h from there as well. After finishing > including windows.h, it will try to include your new version of > memoryapi.h and skip it due to the header guards. > > By adding -I. or similar you would notice the issue. (Unfortunately, our > headers are fairly noisy if used this way - the compilers normally > silence a number of warnings stemming from "system headers" - but in > this case, all the headers are picked from a directory specified by -I, > which isn't treated as the compiler default sysroot, and thus all > warnings are shown.) > >
Oh thanks for pointing this out. I used to have a `-I.` option but forgot it. This will make GCC prefer headers in the current working directory to those from <prefix>/include. There aren't many warnings anyway, usually `-Wno-long-long -Wno-expansion-to-defined` is enough. I discovered a line of C++ comment just now. Will fix it in a moment. -- Best regards, LH_Mouse
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
