On Wed, 29 Nov 2023, Antonin Décimo wrote:
Le mer. 29 nov. 2023 à 12:42, Martin Storsjö <mar...@martin.st> a écrit :
On Wed, 29 Nov 2023, Antonin Décimo wrote:
> Signed-off-by: Antonin Décimo <anto...@tarides.com>
> ---
> .../winpthreads/build-aux/windres-rc | 158 ++++++++++++++++++
> mingw-w64-libraries/winpthreads/configure | 13 +-
> mingw-w64-libraries/winpthreads/configure.ac | 8 +-
> .../winpthreads/src/version.rc | 18 +-
> 4 files changed, 185 insertions(+), 12 deletions(-)
> create mode 100644 mingw-w64-libraries/winpthreads/build-aux/windres-rc
For this change, I'd prefer to split out the change to version.rc to a
separate commit; the change for the windres-rc script is large enough to
warrant focusing only on that, while the rc file change isn't strictly
tied to that.
No problem. Do the changes to the rc file look reasonable? The catch
is that binutils' windres will, IIUC, use the C preproc and get mingw
pre-defined macros, whereas te microsoft tool RC [1] implements its
own C preprocessor and doesn't call MSVC, so it defines a subset of
the macros.
I supposed that the 'GC' in WinPthreadGC' stand for GNU C, so I've
renamed it 'MS' in the default case.
I think the rest of the changes here (and the same for the patches I
didn't comment on) probably are fine, but I'd let someone else have a
second look as well - I just browsed the patchset briefly and commented on
the things I instantly had an opinion on.
// Martin
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
