On Fri, 1 Dec 2023, Antonin Décimo wrote:
+/* On x86, symbols are prefixed with an underscore. */ +# if defined(_M_IX86) +# pragma comment(linker, "/INCLUDE:__tls_used") +# pragma comment(linker, "/INCLUDE:___xl_f") +# elif defined(_M_ARM) || defined(_M_ARM64) || defined(_M_X64) +# pragma comment(linker, "/INCLUDE:_tls_used") +# pragma comment(linker, "/INCLUDE:__xl_f") +# endif
While this is admirably explicit in what it does, I would kinda prefer a plain #else here. Considering potential new future (or past?) unknown archs, it's pretty fair to assume that no extra prefix/suffix is used, and we only need to explicitly enumerate the known exceptions to this norm.
Admittedly, this might feel nitpicky, but the #if i386 #else <everything_else> pattern is quite prevalent across our codebase.
// Martin _______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
