On Tuesday 30 April 2024 11:54:48 Martin Storsjö wrote: > On Sat, 27 Apr 2024, Pali Rohár wrote: > > > CRT header files ensures that time symbols without 32/64 suffixes are not > > emitted. And linker always sees time symbols with explicit 32 or 64 suffix > > name. > > > > When CRT header files are not included then 32-bit MSVC compiler + linker > > treats symbols without "64" suffix name as functions which use 32-bit > > time_t, even for UCRT builds. > > > > Do some in mingw-w64, change I386 time symbol aliases which do not have > > "64" in symbol name, to point to symbols which use 32-bit time_t type. > > Typo in this sentence, I presume you mean "Do the same" or something like > that?
Yes. > Another nitpick for the commit messages in this whole series; the commit > messages talk about I386 and X64, while it actually is generic for 32 and 64 > bit, as we do support armv7 and aarch64 too. So in order to avoid confusion, > especially as there actually are lots of cases that are i386 specific too, > but not these, it would be good to refer more generically to this as 32/64 > bit in these commit messages. I see, that is truth. Anyway, feel free to modify commit messages. I have no problem with it. And I would be happy if somebody else can improve them. _______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
