Hello,

This is a small patch which changes `make check` invocations from

```
make -j$(nproc) check -k -O || { cat testcases/test-suite.log; exit 1; }
```

to

```
make -j$(nproc) check -k -O TESTS=
make -j$(nproc) check -k -O || { cat testcases/test-suite.log; exit 1; }
```

This will compile all tests before actually running them. This makes one small 
difference: if any test fails to compile, it will not try to `cat 
testcases/test-suite.log`, which does not exist yet.

- Kirill Makurin
From ce417b80fea67e98801c8ff6e2c04da8e3b5b4db Mon Sep 17 00:00:00 2001
From: Kirill Makurin <[email protected]>
Date: Fri, 16 Jan 2026 17:59:53 +0900
Subject: [PATCH] github: compile tests before running them

Signed-off-by: Kirill Makurin <[email protected]>
---
 .github/workflows/build.yml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 8a9110f0a..893d90da6 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -621,6 +621,7 @@ jobs:
           ../configure --disable-dependency-tracking 
--prefix=/llvm-mingw/${{matrix.arch}}-w64-mingw32 
--host=${{matrix.arch}}-w64-mingw32 --with-default-msvcrt=${{matrix.crt}} 
--enable-silent-rules ${{ (startsWith(matrix.arch, 'a') && '--disable-lib32 
--disable-lib64') || (matrix.arch == 'x86_64' && '--disable-lib32') || 
'--disable-lib64' }} CPPFLAGS="-Werror"
           make -j$(nproc)
           make -j$(nproc) install
+          make -j$(nproc) check -k -O TESTS=
           make -j$(nproc) check -k -O || { cat testcases/test-suite.log; exit 
1; }
       - name: Build and test winpthreads
         run: |
@@ -631,6 +632,7 @@ jobs:
           cd build
           ../configure --disable-dependency-tracking 
--prefix=/llvm-mingw/${{matrix.arch}}-w64-mingw32 
--host=${{matrix.arch}}-w64-mingw32 --enable-silent-rules CPPFLAGS="-Werror"
           make -j$(nproc)
+          make -j$(nproc) check -k -O TESTS=
           make -j$(nproc) check -k -O || { cat tests/test-suite.log; exit 1; }
 
   testcases-gcc:
@@ -685,6 +687,7 @@ jobs:
           ../configure --disable-dependency-tracking 
--prefix=/gcc-mingw/${{matrix.arch}}-w64-mingw32 
--host=${{matrix.arch}}-w64-mingw32 --with-default-msvcrt=${{matrix.crt}} 
--enable-silent-rules ${{ matrix.arch == 'x86_64' && '--disable-lib32' || 
'--disable-lib64' }} CPPFLAGS="-Werror"
           make -j$(nproc)
           make -j$(nproc) install
+          make -j$(nproc) check -k -O TESTS=
           make -j$(nproc) check -k -O || { cat testcases/test-suite.log; exit 
1; }
       - name: Build and test winpthreads
         run: |
@@ -695,4 +698,5 @@ jobs:
           cd build
           ../configure --disable-dependency-tracking 
--prefix=/gcc-mingw/${{matrix.arch}}-w64-mingw32 
--host=${{matrix.arch}}-w64-mingw32 --enable-silent-rules CPPFLAGS="-Werror"
           make -j$(nproc)
+          make -j$(nproc) check -k -O TESTS=
           make -j$(nproc) check -k -O || { cat tests/test-suite.log; exit 1; }
-- 
2.51.0.windows.1

_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to