Sorry about that. I usually try to write detailed commit messages, but sometimes my head is somewhat empty and cannot come up with anything reasonable. Well, at least until it's time to send the patches to the list. :)
- Kirill Makurin ________________________________ From: Martin Storsj? <[email protected]> Sent: Friday, January 16, 2026 6:31 PM To: mingw-w64-public <[email protected]> Subject: Re: [Mingw-w64-public] github: compile tests before running them On Fri, 16 Jan 2026, Kirill Makurin wrote: > This will compile all tests before actually running them. This makes one > small difference: if any test fails to compile, it will not try to `cat > testcases/test-suite.log`, which does not exist yet. Thanks! It would be nice to have rationale like this included in the commit message. For some of your earlier merged patches, I also slightly lack rationale in the commit messages (even though it might be included in the cover letter email); it's valuable for understanding the motivation for commits afterwards if the motivation is mentioned there, if it's not otherwise clear. (E.g. the recent "reorder declarations" patches for headers - it'd be nice to at least have some words about what kind of reordering you're doing.) This conflicted with another patch for the CI pipeline that I just pushed, but I updated this on top of it. I included the rationale from this mail, and I also mentioned another added advantage from this commit, with respect to the recent conflicting commit, and pushed it now. Thanks! // Martin _______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public _______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
