On Sat, Jan 30, 2016 at 09:03:26PM -0500, Michael McConville wrote: > Chris Bennett wrote: > > Should it be done like this? > > > > int lflag > > int *rflag > > int sflag > > int from_remote > > char **blist > > int *blist_size > > int blist_addrs > > char ***boof > > Close, but you only use spaces there. They usually start > with tabs and then align with spaces, like: > > > int lflag > > int *rflag > > int sflag > > int from_remote > > char **blist > > int *blist_size > > int blist_addrs > > char ***boof > > This has the downside that if you add another level of indentation, you > either have to break the alignment or change every line.
No, that's definitely not OK at all. I sure wouldn't want to review diff's with code changes and full of style changes also. > So there are a > bunch of variants. > > style(9) seems to recommend just using tabs: > > > Put a tab after the first word, i.e., use ‘int^Ix;’ and ‘struct^Ifoo > > *x;’. > > That can get ugly and hard to read, though. So I can change the code,make all that work great, following the existing code style. And then change the style. At that point, why bother? Better things for everyone to do. Chris
