On Thu, Jul 29, 2010 at 10:44:44PM +0000, Miod Vallat wrote: > > On Jul 29 16:35:14, Miod Vallat wrote: > > > > > So please update from cvs and try again. Some things went in that > > > > > might > > > > > have helped this laptop. > > > > > > > > I just did - see http://stare.cz/~hans/.tmp/hp8530w.tar > > > > > > > > The acpitz still claims the CPU is 5731C and shuts down. > > > > It seems to happen more often when on battery. > > > > I disabled acpitz again. > > > > > > Is this with sys/dev/acpi/acpitz.c r1.39 or an older version? > > > > /* $OpenBSD: acpitz.c,v 1.39 2010/07/27 04:28:36 marco Exp $ */ > > > Can you try the following diff and see if it spams your dmesg: > > Index: acpitz.c > =================================================================== > RCS file: /cvs/src/sys/dev/acpi/acpitz.c,v > retrieving revision 1.39 > diff -u -p -r1.39 acpitz.c > --- acpitz.c 27 Jul 2010 04:28:36 -0000 1.39 > +++ acpitz.c 29 Jul 2010 16:46:14 -0000 > @@ -402,8 +402,31 @@ acpitz_getreading(struct acpitz_softc *s > { > u_int64_t val; > > +#if 0 > if (!aml_evalinteger(sc->sc_acpi, sc->sc_devnode, name, 0, NULL, &val)) > return (val); > +#else > + struct aml_value res; > + struct aml_node *node; > + int rc; > + > + node = aml_searchname(sc->sc_devnode, name); > + rc = aml_evalnode(sc->sc_acpi, node, 0, NULL, &res); > + if (rc == 0) { > + switch (res.type) { > + default: > + printf("%s(%s): type %d\n", __func__, name, res.type); > + break; > + case AML_OBJTYPE_INTEGER: > + case AML_OBJTYPE_BUFFER: > + case AML_OBJTYPE_STRING: > + break; > + } > + val = aml_val2int(&res);
val2int is kind of verboten. > + aml_freevalue(&res); > + return val; > + } > +#endif > > return (-1); > }
