Hi David,

I was just about email you, you beat me to it. :) After comparing
Mixxx's SConscript with the CLAM NetworkEditor's SConscruct, I noticed
that you haven't been using pkg-config. I think the problem for us is
that because we're using pkg-config, the system-wide stuff QT4 is being
used instead of the one explicitly set with our qtdir="blah" flag.

Attached is a patch which hopefully fixes this. I think we should have
been using your env.EnableQt4Modules all along.

Let me know if this makes any sense... 

Thanks!
Albert

P.S. Sorry for not pushing r2393 upstream. That commit totally slipped
by me during the summer.


On Thu, 2009-01-08 at 17:18 +0100, David García Garzón wrote:
> qt4.py just uses the pkg-config files so I guess that it should be just a 
> matter of defining PKG_CONFIG_PATH properly so it looks into pkgconfig dir in 
> QTDIR. No warranties though.
> 
> I just merged the changes done at mixxxx r2393 into clam.
> 
> 
> David.
> 
> On Thursday 08 January 2009 16:36:33 Sean M. Pappalardo wrote:
> > So I started nosing around...look at the comments in lines 243, 250, and
> > 256 in src/qt4.py.  Seems there's a bit of hacking going on that may
> > break things. I don't know enough to try to fix this.
> >
> > Sean
> >
> > <<-------------------------------------------------------------------------
> >-------->> This E-Mail message has been scanned for viruses
> > and cleared by >>SmartMail<< from Smarter Technology, Inc.
> > <<-------------------------------------------------------------------------
> >-------->>
> >
> > ---------------------------------------------------------------------------
> >--- Check out the new SourceForge.net Marketplace.
> > It is the best place to buy or sell services for
> > just about anything Open Source.
> > http://p.sf.net/sfu/Xq1LFB
> > _______________________________________________
> > Mixxx-devel mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/mixxx-devel
> 
> 
> 
> ------------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It is the best place to buy or sell services for
> just about anything Open Source.
> http://p.sf.net/sfu/Xq1LFB
> _______________________________________________
> Mixxx-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Index: src/SConscript
===================================================================
--- src/SConscript	(revision 2456)
+++ src/SConscript	(working copy)
@@ -400,13 +400,30 @@
 			Exit(1)
 		else:
 			#Grabs the QT4 include paths
+			"""
 			env.ParseConfig('pkg-config QtCore --silence-errors --cflags --libs')
 			env.ParseConfig('pkg-config Qt3Support --silence-errors --cflags') #QT3 support breaks the build
 			env.ParseConfig('pkg-config QtGui --silence-errors --cflags --libs')
 			env.ParseConfig('pkg-config QtXml --silence-errors --cflags --libs')
 			env.ParseConfig('pkg-config QtOpenGL --silence-errors --cflags --libs')
-			# Might be missing $QTDIR/include/Qt still...
+			"""
+			#Try using David's qt4.py's Qt4-module finding thingy instead of pkg-config.
+			#(This hopefully respects our qtdir=blah flag while linking now.)
+			env.EnableQt4Modules([
+			'QtCore',
+			'QtGui',
+			'QtOpenGL',
+			'Qt3Support',
+			'QtXml',
+			'QtSvg',
+			#'QtUiTools',
+			#'QtDesigner',
+			#'QtWebKit',
+			],
+			debug=False,
+			)
 
+
 		#Check for libasound (libasound2?) (needed for ALSA seq MIDI support)
 		if not conf.CheckLib('asound') and not conf.CheckForPKG('alsa', '1.0.10'):
 			print "Did not find libasound (aka. libasound2), exiting!"

------------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It is the best place to buy or sell services for
just about anything Open Source.
http://p.sf.net/sfu/Xq1LFB
_______________________________________________
Mixxx-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Reply via email to