Hello, all! The feedback week has passed and I've uploaded what will hopefully be the last revision [1]. I've assigned two reviewers to the patch, but feel free to drive-by review!
Thanks! - Mike (:mcomella) [1]: https://bugzilla.mozilla.org/show_bug.cgi?id=910859#c75 On Fri, Nov 15, 2013 at 12:41 PM, Michael Comella < [email protected]> wrote: > Hello again. > > I've uploaded a (hopefully) near final revision of the patch to the bug > [1] and am requesting feedback from a wider audience on it! Please feel > free to give drive-by feedback; provided there's no major pushback, I'll be > waiting about a week before requesting the final review. > > For further details on the state of the patch, I explained it in the bug > at [1]. > > Thanks! > - Mike (:mcomella) > > [1]: https://bugzilla.mozilla.org/show_bug.cgi?id=910859#c45 > > > > On Fri, Nov 1, 2013 at 12:47 PM, Michael Comella < > [email protected]> wrote: > >> Hello, everyone. >> >> I took this effort over from Lucas a short while ago and recently >> uploaded my latest revisions to his initial patch [1]. If you'd like to >> contribute feedback, please do so! >> >> Thanks! >> - Mike (:mcomella) >> >> [1]: https://bugzilla.mozilla.org/show_bug.cgi?id=910859#c18 >> >> >> On Wed, Sep 4, 2013 at 2:47 AM, Lucas Rocha <[email protected]> wrote: >> >>> Hi all, >>> >>> ----- Original Message ----- >>> > If you ever worked on tests based on our robocop harness, you probably >>> > noticed how unpleasant it is to work on them. Our current UI testing >>> code >>> > suffers from two major problems: >>> > >>> > - Inconsistency/verbosity: The tests and their underlying API are very >>> > ad-hoc. We're duplicating a lot of code, the code is very verbose, and >>> the >>> > current structure with BaseTest subclasses doesn't scale well and >>> almost >>> > inevitably leads to bloated classes with tons of unrelated APIs. >>> > - Unreliability: The tests themselves are unreliable in many ways. >>> Each test >>> > pokes the UI in a different way to check the same things. >>> >>> I deeply care about keeping a nice and positive atmosphere in the our >>> community. The bit above sounds overly negative and critical. I realize >>> that many people have put energy into the current UI testing code and it's >>> definitely not my intention to diminish anyone's contributions. >>> >>> I don't want to set such a bad precedent in our community. So, my >>> apologies for the negative tone here. >>> >>> I'll do it better next time. Promise :-) >>> >>> --lucasr >>> _______________________________________________ >>> mobile-firefox-dev mailing list >>> [email protected] >>> https://mail.mozilla.org/listinfo/mobile-firefox-dev >>> >> >> >
_______________________________________________ mobile-firefox-dev mailing list [email protected] https://mail.mozilla.org/listinfo/mobile-firefox-dev
