Re: mod_perl 1.99 and Apache::compat

[Dave Rolsky]

On Sun, 7 Apr 2002, Dave Rolsky wrote:

> I also found a few tiny bugs in Apache::compat.
>
> - The read() call in send_fd_length needs to be CORE::read.
>
> - In the last elsif in size_string, the size variable is missing its
> dollar sign ($).

Here's a patch:

--- compat.pm.~1.35.~   Sat Mar 23 20:38:01 2002
+++ compat.pm   Sun Apr  7 14:19:46 2002
@@ -259,7 +259,7 @@
         $len = IOBUFSIZE;
     }

-    while (read($fh, $buff, $len)) {
+    while (CORE::read($fh, $buff, $len)) {
         $total_bytes_sent += $r->puts($buff);
     }

@@ -369,7 +369,7 @@
     elsif ($size < 1048576) {
         $size = sprintf "%4dk", ($size + 512) / 1024;
     }
-    elsif (size < 103809024) {
+    elsif ($size < 103809024) {
         $size = sprintf "%4.1fM", $size / 1048576.0;
     }
     else {