On Mon, Apr 29, 2002 at 12:39:32AM +1000, Ken Williams wrote:
> I sent a message earlier today saying that this patch seems to help 
> things, but I just noticed something disturbing.  After hand-applying 
> this patch to my CWD.pm from 5.6.1, I ran a 'perl Makefile.PL' for a 
> different module (Apache::SSI), and it created the Makefile not in the 
> current directory, but in my *home* directory!  Weird.  I don't know why 
> it happened yet, but obviously this isn't a good thing.

Likely something passed chdir() an undef or '' which means "chdir to
$ENV{HOME}".  Unfortunate shell holdover.  Likely the pwd/chdir combination
in eval_in_subdirs().

--- lib/ExtUtils/MakeMaker.pm   24 Apr 2002 05:30:36 -0000      1.44
+++ lib/ExtUtils/MakeMaker.pm   29 Apr 2002 04:06:20 -0000
@@ -79,7 +79,8 @@
 sub eval_in_subdirs {
     my($self) = @_;
     use Cwd qw(cwd abs_path);
-    my $pwd = cwd();
+    my $pwd = cwd() || die "Can't figure out your cwd!";
+
     local @INC = map eval {abs_path($_) if -e} || $_, @INC;
     push @INC, '.';     # '.' has to always be at the end of @INC
 


-- 

Michael G. Schwern   <[EMAIL PROTECTED]>    http://www.pobox.com/~schwern/
Perl Quality Assurance      <[EMAIL PROTECTED]>         Kwalitee Is Job One
You're the sickest teenager I've ever set my wallet on.

Reply via email to