On Wednesday 24 March 2004 12:51 pm, Stas Bekman wrote:
> Beau E. Cox wrote:
> > On Wednesday 24 March 2004 10:03 am, Stas Bekman wrote:
> >>Beau E. Cox wrote:
> >>>On Tuesday 23 March 2004 10:14 am, Stas Bekman wrote:
> >>>>Thanks for the report, Beau. I'm looking at it. I'm going to rewrite
> >>>> the code not to load Apache::Request till we know that we have found
> >>>> the right version.
> >>>
> >>>OK. Send a patch if you want a pre-test on my platform.
> >>
> >>Beau, Please give a try to the currect cvs.
> >
> > Current cvs: tests OK
>
> Cool, thanks Beau!
>
> > Still get:
> >
> > Starting httpd[Wed Mar 24 12:03:42 2004] [error] Subroutine
> > Apache::Status::status_mason0001 redefined
> > at
> > [...]
> >
> > with warnings on. (With or without Apache::Reload.)
> >
> > Warnings off: OK.
> >
> >>I haven't dealt with the redefined warning. If it's still a problem,
> >> please show us a simple reproducable test (with Mason). Thanks.
> >
> > Working on a simple test; will try to send tonight.
> > 'Simple test' => read 'Hard'.
>
> I think I know the reason, please try with this patch:
>
> Index: lib/Apache/Status.pm
> ===================================================================
> RCS file: /home/cvs/modperl-2.0/lib/Apache/Status.pm,v
> retrieving revision 1.24
> diff -u -r1.24 Status.pm
> --- lib/Apache/Status.pm        24 Mar 2004 20:42:04 -0000      1.24
> +++ lib/Apache/Status.pm        24 Mar 2004 22:50:58 -0000
> @@ -122,6 +122,7 @@
>       my($self, $key, $val, $sub) = @_;
>       $status{$key} = $val;
>       no strict;
> +    no warnings 'redefine';
>       *{"status_${key}"} = $sub if $sub and ref $sub eq 'CODE';
>   }
>

YES - Patch works fine!

Aloha => Beau;

PS: Get some sleep ;)


-- 
Report problems: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html
List etiquette: http://perl.apache.org/maillist/email-etiquette.html

Reply via email to