-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Friday 22 October 2004 19:10, Stas Bekman wrote: > > I thought about it this night and realized that I need not to traverse > > these lists at all. At first ist was a try to guess what to call > > ap_input_filter_remove or ap_output_filter_remove. But if the filter is > > not in an appropriate chain these functions do simply nothing. Hence I > > can call them both if I don't know what kind of filter it is. > > I wish we could somehow know what kind of filter is in question. In which > case we won't have needed to run wasteful CPU cycles. BTW, I've reversed > the order of removal, since I believe we will have many more output > filters than input ones. What do you think?
Yes, I agree that there will be much more output filters but since we cannot not determine if ap_remove_output_filter has actually removed the filter we have to call ap_remove_input_filter in any case. Hence the calling order is all the same. > > The attached patch contains the updated Apache__Filter.h and a test that > > removes INCLUDES from the output chain and DEFLATE from input. > > Excellent. I've massaged both quite a bit to adher to the style and > simplify where it made sense (And found a perl bug in regex qr//m on the > way :( see my latest report to p5p) Looks good to me > I'll commit it as soon as Philippe releases 1.99_17 (today?) Thanks Torsten -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) iD8DBQFBeVL0wicyCTir8T4RAiCiAKCT1gXWqPle5r08q7BSSFEhYKvr7QCdGedI Nszf0Y4AANkitUcjzn2CeDM= =iQl2 -----END PGP SIGNATURE----- -- Report problems: http://perl.apache.org/bugs/ Mail list info: http://perl.apache.org/maillist/modperl.html List etiquette: http://perl.apache.org/maillist/email-etiquette.html
