Perrin Harkins wrote:
> Philippe M. Chiasson wrote:
>
>> + my $Idx;
>> + {
>> + local $Data::Dumper::Indent = 0;
>> + local $Data::Dumper::Terse = 1;
>> + $Idx = Dumper([EMAIL PROTECTED]);
>
> This may also be significantly slower than what it's replacing, and
> since this is just calculating a cache key, people expect it to be fast.
> If this does solve the problem, it should be optional, unless
> benchmarks show it to be a negligible hit.Absolutely, I was just making a point clear ;-) If you look at the existing code, there is a partial attempt at this already, with a loop unrolling HASH refs in the arguments, it's just not dealing with ARRAY refs correctly. > Maybe more to the point, I'm not sure it's a good idea to shoot in the > dark like this without knowing how DBD::Multiplex uses this data or > what's in it. Well, I am not sure what the DBI api says, but I would assume that what Apache::DBI needs to be able to do is to identify 2 connect() attempts for the same dsn. And that, IMO, is when the arguments to connect() are identical in value, not reference, but I could be wrong. -------------------------------------------------------------------------------- Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5 http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5
signature.asc
Description: OpenPGP digital signature
