Philip M. Gollucci wrote:
A release candidate for Apache-SizeLimit 0.91-RC1 is now available.
http://people.apache.org/~pgollucci/asl/Apache-SizeLimit-0.91-rc1.tar.gz
Please download, test, and report back.
I broke it! :) [1], httpd 2.2.3, mp2.0.3, perl 5.8.8, darwin
Here's my suggested patch to handle this. Only problem is it doesn't
tell you why it skipped - I know why but I don't count...
--- t/apache2/all.t.orig 2006-12-06 01:07:41.000000000 -0800
+++ t/apache2/all.t 2006-12-06 01:06:46.000000000 -0800
@@ -25,6 +25,9 @@
elsif ( $Config{'osname'} eq 'MSWin32' ) {
$ok &= need_module('Win32::API');
}
+ elsif ( $Config{'osname'} eq 'darwin' ) {
+ return;
+ }
$ok &= need_min_apache_version("2.0.48");
Here's the error log snippet - I didn't know sizelimit wasn't supported
on darwin.
[Wed Dec 06 01:01:28 2006] [error] [client 127.0.0.1] failed to resolve
handler `TestApache2::basic': Apache::SizeLimit is not implemented on
your platform. at
/Users/phred/dev/Apache-SizeLimit-0.91-rc1/blib/lib/Apache/SizeLimit/Core.pm
line 161.
[1]
[EMAIL PROTECTED] ~/dev/Apache-SizeLimit-0.91-rc1 $ make test
/usr/bin/perl -Iblib/arch -Iblib/lib \
t/TEST -clean
setting ulimit to allow core files
ulimit -c unlimited; /usr/bin/perl
/Users/phred/dev/Apache-SizeLimit-0.91-rc1/t/TEST -clean
APACHE_TEST_GROUP=
APACHE_TEST_HTTPD=/Users/phred/dev/sl/httpd2/bin/httpd APACHE_TEST_PORT=
APACHE_TEST_USER= APACHE_TEST_APXS=/Users/phred/dev/sl/httpd2/bin/apxs \
/usr/bin/perl -Iblib/arch -Iblib/lib \
t/TEST -bugreport -verbose=0
setting ulimit to allow core files
ulimit -c unlimited; /usr/bin/perl
/Users/phred/dev/Apache-SizeLimit-0.91-rc1/t/TEST -bugreport -verbose=0
/Users/phred/dev/sl/httpd2/bin/httpd -d
/Users/phred/dev/Apache-SizeLimit-0.91-rc1/t -f
/Users/phred/dev/Apache-SizeLimit-0.91-rc1/t/conf/httpd.conf -D APACHE2
-D PERL_USEITHREADS
using Apache/2.2.3 (prefork MPM)
waiting 60 seconds for server to start: ok (waited 0 secs)
server localhost:8529 started
t/apache/all......................skipped
all skipped: apache version 1 required, this is version 2
t/apache2/basic...................request has failed (the response code
was: 500)
see t/logs/error_log for more details
t/apache2/basic...................dubious
Test returned status 255 (wstat 65280, 0xff00)
t/apache2/check_n_requests2.......FAILED before any test output arrived
t/apache2/deprecated..............FAILED before any test output arrived
t/apache2/zzz_check_n_requests....FAILED before any test output arrived
t/pod.............................skipped
all skipped: Test::Pod 1.14 required for testing POD
Failed Test Stat Wstat Total Fail Failed List of
Failed
-------------------------------------------------------------------------------
t/apache2/basic.t 255 65280 ?? ?? % ??
t/apache2/check_n_requests2.t ?? ?? % ??
t/apache2/deprecated.t ?? ?? % ??
t/apache2/zzz_check_n_requests.t ?? ?? % ??
2 tests skipped.
Failed 4/6 test scripts, 33.33% okay. 25/25 subtests failed, 0.00% okay.
*** Pending a successful release, This package will be integrated into
*** both mod_perl 1.x and mod_perl 2.x CORE distributions.
Changes since 0.9:
-------------------
*********** HEADS UP - SHARED CODE BASE - HEADS UP ***********
Apache-SizeLimit has been hybridized.
It has been split into 3 packages.
1) Apache::SizeLimit - User API for httpd 1.3.x / mod_perl 1.x
2) Apache2::SizeLimit - User API for httpd 2.x / mod_perl 2.x
3) Apache::SizeLimit::Core - Interal Shared Functionality
_NEVER_ use this module directly.
[Philip M. Gollucci <[EMAIL PROTECTED]>]
Fix Can't call method "child_terminate" on an undefined value
By add_cleanup_handler() pass $r to _exit_if_to_big() via shift
[David Wheeler <[EMAIL PROTECTED]>]
Added a SUPPORT section to the docs.
[Dave Rolsky <[EMAIL PROTECTED]>]
