Jonas Brømsø Nielsen wrote:
I agree with Chris here.

And the idea is not to have main package version drifting from distribution version or the other way around.

jonasbn

On 13/09/2009, at 15.18, Chris Dolan wrote:

On Sep 13, 2009, at 7:36 AM, Shawn H Corey wrote:

Jonas Brømsø Nielsen wrote:
  dist_name         => 'Workflow',
  dist_version_from => 'lib/Workflow.pm',

I would be tempted to:

dist_version_from => 'lib/Workflow/VERSION.pm',

Comments?

I thought about that too and rejected it as unnecessary complexity. You still need a $VERSION in Workflow.pm anyway or else Workflow->VERSION() doesn't work right, so why not just put the version in Workflow.pm in the first place.

Chris



Because then you have to update more than one module. Shawn's Programming Rules #5 <http://www.perlfoundation.org/perl5/index.cgi?shawn_h_corey#shawn_s_programming_rules>: 5. If you have the same data in two places, they will get out off sync. Write the code to detect and correct this now, because when it happens, it will be too late.

Try:

package Workflow;
use Workflow::VERSION;
$Workflow::VERSION = $Workflow::VERSION::VERSION;


--
Just my 0.00000002 million dollars worth,
  Shawn

Programming is as much about organization and communication
as it is about coding.

I like Perl; it's the only language where you can bless your
thingy.

Reply via email to