# from Ken Williams
# on Tuesday 16 December 2008 14:12:

>The only unsightliness I see is this:
>
>-----------------
>t/ext.................1/186
>get_options not a class method () at t/ext.t line 94
>get_options not a class method () at t/ext.t line 101
>-----------------
>
>I haven't looked into it.  If it's not a quick fix let's ship.

That's the warning from my refactoring of the attributes generation.  I 
think the code that issues the warning needs to go into the wild for a 
rev or two (that is, "using attributes as class methods is deprecated") 
so we can see if anyone complains.

    # This is only here to deprecate the historic accident of calling
    # properties as class methods - I suspect it only happens in our
    # test suite.
    unless(ref($self)) {
      carp("\n$property not a class method (@_)");
      return;
    }

See r12175 (just checked in.)  This gives the same result with regard to 
our test suite, but without hitting the warning.  Should be ready to 
bump the version number and ship if you want to do that Ken.

--Eric
-- 
A counterintuitive sansevieria trifasciata was once literalized 
guiltily.
--Product of Artificial Intelligence
---------------------------------------------------
    http://scratchcomputing.com
---------------------------------------------------

Reply via email to