On Sun, Jul 12, 2009 at 10:49 PM, Elliot Shank <p...@galumph.com> wrote:
> Elliot Shank wrote: > >> David Golden wrote: >> >>> Could you please post the output you're seeing? >>> >> >> "Cannot determine source for xt/author at >> /Users/elliot/opt/perl/perl-5.10.0-64bit-threads/lib/5.10.0/Test/Harness.pm >> line 150" >> >> >> And please confirm that xt/author exists and has *.t files? I tried it >>> both >>> with *.t files only in xt and then in xt/author and saw what I expected. >>> >> >> Well, dang. It turns out that this was a mis-copy of the xt directory >> from another distro. >> >> Sorry. First time actually using 0.34 and assumed something changed. >> *sigh* >> > > Actually, this begs the question of whether M::B should be producing an > error instead of letting T*::Harness deal with it. > > I volunteer to make a patch if this is answered in the affirmative. > Maybe a warning? But the logic is kinda hairy since test_files could be: * actual file * actual directory * glob pattern Maybe if $thing doesn't look like a glob pattern and not -e $thing, then warn/die? If recursive isn't set, then even an actual directory that exists is probably an error. I'd suggest writing some test cases and post to the list to see if people agree with the logic before actually spending your time implementing something. Thank you for volunteering! -- David
