On 16/11/05 20:17, Ed Ravin wrote:
Hans, thanks for posting the two patches! I hate to look a gift horse
in the mouth, but I have a couple of concerns:
No worry about the gift horse. I happen to disagree though. Not that
its a big issue.
This is not unique to ext2/ext3 filesystems - it's implemented on most
Unix filesystems, and as the OP said, the percentage of reserved space
is configurable.
Well, let he who has another type of filesystem add his own if clause.
And yes, it is configurable. I've never seen anybody do configure it
though. There's no need. The amount of diskspace you win by
configuring it, is obsolete in two months when the next generation of
diskdrives comes out with double the capacity. It *could* be
configured, yes, but I'm not here to make life easier for some
hypothetical person who tweaks a setting that nobody ever tweaks. I'm
here to solve my own problems. And it's keeping me pretty busy at that.
Thus, I recommend that you make the "reservation compensation" a
configurable option, turned off by default, so that people who upgrade
to the new version aren't surprised by the change in behavior.
Well, they *should* be surprised. Only 1/2 a :-) here. They do not
have as much diskspace available as they thought they had. If they've
configured a limit of 5 % they only get an alert when the disk is 100 %
full. That's not good behaviour to me. It actually looks more like a
bug, though technically it's not. To me free diskspace is what "df"
reports. But YMMV.
Likewise for the "swap space" patch - that too should be
an option, perhaps a more generic option like
--include-filesystems <regexp>
which would check space on any filesystem whose description matched
the <regexp>.
Well, apart from the trivial nitpick that swapspace is not a filesystem,
*and* under windows it's called "Virtual Memory" while under Linux its
called "Swap Space", this could still be called --include-swapspace but
then again, who wouldn't appreciate the extra, relevant, if not to say
important information the monitor now reports. So, if anything, I would
be in favour of an --exclude-swapspace, to accomodate some hypothetical
person who would be annoyed by the extra information the monitor is
giving out. I'm not overwhelmed.
Come to think of it, it could be as simple as a default setting in
snmpdiskspace.cf:
* "Swap Space" 0%
* "Virtual Memory" 0%
But it's only a few lines of code. You can do with it whatever you
want. I won't be traumatized if you don't see it fit to use them.
Neither will I if you decide to surround them with some sort of if
clause. These are just two hacks that work for me, and I just posted
them back to the list.
To me mon is a day-to-day lifesaver, giving me, on an almost daily
basis, alerts of the most important kind. I wouldn't know what to do
without it. Competing products don't cut it.
Oh, yeah, I also have a "file.monitor" which monitors (log) files for
certain strings. That has come from a rudimentary hack to quite an
elaborate script. I'll post it after I've brushed it up.
Cheers,
--
| Hans Kinwel
| [EMAIL PROTECTED]
_______________________________________________
mon mailing list
[email protected]
http://linux.kernel.org/mailman/listinfo/mon
