Hi, I forgot to mention, that the second check is needed because it's also possible, that the call to "mono_find_jit_opcode_emulation" returns null in a little different setup. But I just saw that Zoltan closed and fixed (or vice versa :)) the bug with a fix similar to what you suggested.
And yes I also thing that this is a nicer fix ;-) Thanks a lot for your replies and the fast fixing on this issue. Mirko Von: Rodrigo Kumpera [mailto:kump...@gmail.com] Gesendet: Freitag, 22. Juli 2011 16:16 An: Mirko Wischer Cc: mono-devel-list@lists.ximian.com Betreff: Re: [Mono-dev] Segfault in JIT - How to fix? On Fri, Jul 22, 2011 at 7:51 AM, Mirko Wischer <mirko.wisc...@sma.de<mailto:mirko.wisc...@sma.de>> wrote: Hi, I tried to make a patch that fixes the problem - see attached file. My example code now works without problems. I also attached the patch to novell-mono-bugzilla, but I'm not really sure if that's the right place. Bye Mirko You don't need the second check. The assert is there to make sure we have everything in sync. I believe a nicer fix would be to do something like " if (!ins->next) { ins->next = OP_NOP; break; }" only as it would reduce the diff size and nesting levels. The best way to get the fix in is to fork mono from github and make a pull request. Reference the bug number on it and we'll take care of the rest. Thanks a lot for working on this. Rodrigo ___________________________________________________ SMA Solar Technology AG Aufsichtsrat: Guenther Cramer (Vorsitzender) Vorstand: Juergen Dolle, Roland Grebe, Uwe Hertel, Pierre-Pascal Urbon, Marko Werner Handelsregister: Amtsgericht Kassel HRB 3972 Sitz der Gesellschaft: 34266 Niestetal USt-ID-Nr. DE 113 08 59 54 WEEE-Reg.-Nr. DE 95881150 ___________________________________________________
_______________________________________________ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
