How about this one?
Jonathan
Alex Shulgin wrote:
Jonathan Pobst wrote:
Does the attached patch fix the issue for you?
Well, partially.
The height is determined correctly, but there's still extra
decoration to the left and right of the hosted item as demonstrated
on attached screenshot.
Like your first email says, we need to figure out why that 68 is
there. It is a crutch to support the common case, but it messes up
less common cases like this.
While your patch works around the issue, its not the correct solution.
This 68 needs to be dynamically calculated from something, whether its
margins or paddings or preferred sizes of MenuItems.
I will try to look at this some this week if you don't want to dig any
deeper.
Hi,
Thanks for your responses!
Apparently, .NET ToolStripDropDown behaves differently when it's hosted
inside ToolStrip and when it's used standalone.
I'm attaching a sample .cs and a PNG screenshot to demonstrate the
difference.
So possibly, the correct solution would be to introduce some flag that
indicates the drop down is used standalone (or determine this from the
existing data like missing Owner, etc.) and adjust layout and painting
accordingly.
--
Alex
------------------------------------------------------------------------
Index: ToolStripDropDown.cs
===================================================================
--- ToolStripDropDown.cs (revision 128017)
+++ ToolStripDropDown.cs (working copy)
@@ -577,7 +577,7 @@
protected override void OnLayout (LayoutEventArgs e)
{
- // Find the widest menu item
+ // Find the widest menu item, so we know how wide to
make our dropdown
int widest = 0;
foreach (ToolStripItem tsi in this.Items) {
@@ -586,12 +586,13 @@
tsi.SetPlacement (ToolStripItemPlacement.Main);
- if (tsi.GetPreferredSize (Size.Empty).Width >
widest)
- widest = tsi.GetPreferredSize
(Size.Empty).Width;
+ widest = Math.Max (widest, tsi.GetPreferredSize
(Size.Empty).Width + tsi.Margin.Horizontal);
}
+ // Add any padding our dropdown has set
+ widest += this.Padding.Horizontal;
+
int x = this.Padding.Left;
- widest += 68 - this.Padding.Horizontal;
int y = this.Padding.Top;
foreach (ToolStripItem tsi in this.Items) {
@@ -602,16 +603,20 @@
int height = 0;
- if (tsi is ToolStripSeparator)
+ Size preferred_size = tsi.GetPreferredSize
(Size.Empty);
+
+ if (preferred_size.Height > 22)
+ height = preferred_size.Height;
+ else if (tsi is ToolStripSeparator)
height = 7;
else
height = 22;
- tsi.SetBounds (new Rectangle (x, y, widest,
height));
+ tsi.SetBounds (new Rectangle (x, y,
preferred_size.Width, height));
y += tsi.Height + tsi.Margin.Bottom;
}
- this.Size = new Size (widest + this.Padding.Horizontal,
y + this.Padding.Bottom);// + 2);
+ this.Size = new Size (widest, y + this.Padding.Bottom);
this.SetDisplayedItems ();
this.OnLayoutCompleted (EventArgs.Empty);
this.Invalidate ();
Index: ToolStripDropDownButton.cs
===================================================================
--- ToolStripDropDownButton.cs (revision 128017)
+++ ToolStripDropDownButton.cs (working copy)
@@ -104,7 +104,9 @@
#region Protected Methods
protected override ToolStripDropDown CreateDefaultDropDown ()
{
- return base.CreateDefaultDropDown ();
+ ToolStripDropDownMenu tsdd = new ToolStripDropDownMenu
();
+ tsdd.OwnerItem = this;
+ return tsdd;
}
protected override void OnMouseDown (MouseEventArgs e)
Index: ToolStripItem.cs
===================================================================
--- ToolStripItem.cs (revision 128017)
+++ ToolStripItem.cs (working copy)
@@ -1870,7 +1870,7 @@
return true;
if (!(this.Owner is ToolStripDropDownMenu))
- return true;
+ return false;
ToolStripDropDownMenu tsddm =
(ToolStripDropDownMenu)this.Owner;
_______________________________________________
Mono-winforms-list maillist - Mono-winforms-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-winforms-list
