Lapo Luchini wrote: > Thomas Keller wrote: >>> I started a thread upstream to inquiry on that: >>> http://www.cygwin.com/ml/cygwin/2009-09/msg00234.html >>> but in the meantime I propose to: >>> a. always launch the test programs using LANG=C >>> (it uses UTF8 on Cygwin and seems like a nice change also on other >>> systems, not to depend on system locale with test output) >>> b. change that test to avoid non-UTF8 filenames much like on OSX > > I was also meaning to add a 'export LANG=C' line at the beginning of > run_lua_tests in the same commit but I can't find how that is generated!??
I found it thanks to Timothy (run_%_tests in Makefile.am) and, adding
that, it works ok even if the previous environment is ISO-8859-1.
Before committing what I think it's a rather ugly patch (adding LANG=C
to the script) I tried using this approach, but it didn't work properly:
--- testlib.lua a019d00ccc1a886e692abd143d8d62416d7dbf8e
+++ testlib.lua 0c442921922f2a426334d2c38488f2acace48422
@@ -877,6 +877,7 @@ function run_tests(debugging, list_only,
"LC_TIME" }) do
set_env(name,"C")
end
+ os.setlocale("C");
So in the end I committed 3b00b8a24b64305df75f9530435e7d3e2cb37b50.
Already tested it on Cygwin (still going, but seems rather good so far)
and under FreeBSD (finished with no errors).
--
Lapo Luchini - http://lapo.it/
“Endure. In enduring, grow strong.” (Dak'kon, videogame "Torment", 1999)
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Monotone-devel mailing list Monotone-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/monotone-devel
