Hey Aaron, I'll be contacting you shortly re: the offline items, as far as the way to do this code (and any future coded I might do) what are best practices for things like reliance on other plugins in More, code style, and general procedure that you think I should follow? I want to make sure that what I am doing is consistent with how Mootools as a whole would want them done.
Thanks, Daniel On Oct 1, 3:58 pm, Aaron Newton <aa...@iminta.com> wrote: > On Thu, Oct 1, 2009 at 3:38 PM, csuwldcat <daniel...@gmail.com> wrote: > > > Haha oh you mean the one I reported ;) No, it does not, but I will > > add that in. Basically what I was thinking for a fix there was this: > > Clone the surrounding node at its height/width and padding dimensions > > (for cases, such as my own, where width 100% sliders are being used) > > then do a measure on the element when it is properly z-indexed out of > > sight and visibility hidden. > > I'd rather you use Element.measure. > > > BTW - Aaron, I would like to talk with you off line about an > > opportunity that may be possible for Mootools. I recently (yesterday) > > secured a job as a PM with a foxy browser manufacturer and there are > > some areas where Mootools could be greatly benefited if I could get > > some collaboration... > > Feel free to drop me an email. aaron [at] mootools | net > > > > > > > On Oct 1, 10:17 am, Aaron Newton <aa...@iminta.com> wrote: > > > also, does this new version address this issue? > >https://mootools.lighthouseapp.com/projects/24057-mootoolsmore/ticket... > > > > On Thu, Oct 1, 2009 at 9:11 AM, csuwldcat <daniel...@gmail.com> wrote: > > > > > I fully agree Oskar, I just looked it over and i think it would only > > > > be about 2 lines to make that an option that can be fully turned > > > > off ;) > > > > > - Daniel > > > > > On Oct 1, 9:04 am, Oskar Krawczyk <oskar.krawc...@gmail.com> wrote: > > > > > As much as I love the refactoring you've done, I'm gonna put it out > > > > there: > > > > > how about making the collision constrains optional? I'm sure I'll > > find > > > > > myself in a situation when I just want to move one of the pin all the > > way > > > > > from left to right, and being constrained by any other pins that are > > in > > > > the > > > > > way. > > > > > O. > > > > > > ___ > > > > > > Oskar Krawczykhttp://nouincolor.com > > > > > > On Thu, Oct 1, 2009 at 16:43, csuwldcat <daniel...@gmail.com> wrote: > > > > > > > This could be regarded as a complete version, I knocked out an > > issue > > > > > > with the dragCollision custom event and I am thinking this is a > > good > > > > > > candidate for serious testing under one condition: > > > > > > > When a user initially sets a pin on the first init of a new slider > > pin > > > > > > and they set it to collide with another pin's spacing or step > > > > > > position, there is an error. I could do something to solve that by > > > > > > assessing the closest "gap" that the pin set try could fail to but > > > > > > before I went down the rabbit's hole on that, I wanted to get your > > > > > > take on what we should and shouldn't be rounding the corners for? > > I > > > > > > mean it happens only on init if the person tries to do something > > they > > > > > > shouldn't be doing under any stretch of logic. Let me know what you > > > > > > both think, other than that, I think it is set! > > > > > > > http://mooshell.net/MXC9s/ > > > > > > > On Sep 30, 8:55 am, csuwldcat <daniel...@gmail.com> wrote: > > > > > > > Ugg, removed one line of old unneeded null check: > > > > > >http://mooshell.net/SvG9y/ > > > > > > > > On Sep 30, 2:58 am, Oskar Krawczyk <oskar.krawc...@gmail.com> > > wrote: > > > > > > > > > IE6 = OKIE6-standalone = OK > > > > > > > > IE7 = OK > > > > > > > > > Firefox 2 (Mac) = OK > > > > > > > > Firefox 3 (Mac) = OK > > > > > > > > Firefox 3 (Win) = OK > > > > > > > > > Safari 3 (Mac) = OK > > > > > > > > Safari 4 (Mac) = OK > > > > > > > > Safari 4 (Win) = OK > > > > > > > > > Nice! We'll see how the Unit Test goes :-) > > > > > > > > > ___ > > > > > > > > > Oskar Krawczykhttp://nouincolor.com > > > > > > > > > On Tue, Sep 29, 2009 at 18:25, csuwldcat <dbuch...@auctiva.com > > > > > wrote: > > > > > > > > > > I tested it in FF 3/3.5, Chrome, IE7/8 > > > > > > > > > > I have an example package and one further commit to make to > > add > > > > > > > > > onDragCollision and onSetCollision events to the slider > > options > > > > ;) > > > > > > > > > > Where can I do the rest of what you described? > > > > > > > > > > On Sep 29, 8:30 am, Aaron Newton <aa...@iminta.com> wrote: > > > > > > > > > > Excellent work Daniel! > > > > > > > > > > > @Aaron - I did a commit on the More Slider source, is that > > what > > > > I > > > > > > > > > > > > should have done? > > > > > > > > > > > Yes, in theory. Github is down so I can't verify. > > > > > > > > > > > Here's the fun question: did you rewrite the docs and unit > > > > test? If > > > > > > not, > > > > > > > > > I > > > > > > > > > > don't think you're done yet! Welcome to the world of > > software > > > > > > releases. > > > > > > > > > It > > > > > > > > > > takes 1/2 the time to write the code, and another 1/2 to > > > > document > > > > > > and > > > > > > > > > test > > > > > > > > > > it. > > > > > > > > > > > Speaking of testing, did you test it across all our > > supported > > > > > > browsers? > > > > > > > > > > > I know, you hate me. Now back get to work.
