I have a few lines to correct per a code review that was done, nothing broken about it, just code adherance stuff. How about I make a by-the- end-of-the-weekend commitment to have it 100%!
PS - If you would do the UI for JetpackShell, I could probably talk to a guy and get this bumped up to tonight or tomorrow... :) ...just screwing with you Oskar! - Daniel On Dec 4, 4:43 am, Oskar Krawczyk <oskar.krawc...@gmail.com> wrote: > Hey, what happened with this? > > I was sure this was already implemented in 1.2.4.2. > > ___ > > Oskar Krawczykhttp://nouincolor.com > > On Tue, Oct 6, 2009 at 8:20 PM, Aaron Newton <aa...@iminta.com> wrote: > > Looking at the code from here (http://mooshell.net/z27Ej/), my comments: > > >http://paste.mootools.net/f4797d58f > > > On Tue, Oct 6, 2009 at 1:05 PM, Aaron Newton <aa...@iminta.com> wrote: > > >> Back from vacation and ready to work on mootools stuff... > > >> Hey Aaron, I'll be contacting you shortly re: the offline items, as > >>> far as the way to do this code (and any future coded I might do) what > >>> are best practices for things like reliance on other plugins in More, > >>> code style, and general procedure that you think I should follow? I > >>> want to make sure that what I am doing is consistent with how Mootools > >>> as a whole would want them done. > > >> This is a little too vague for me to answer. Code style is pretty > >> consistent throughout -core and -more, so you should look at what's there > >> for guidance. There's also a style guide on github, but it's not 100% > >> complete. > > >> As for dependencies, you should create a user test. Create one of those > >> and if your dependencies (listed in scripts.json) are off, the test will > >> fail to load. That's the easiest way to test for those. > > >> Before I pull your code in I'll go over it and fix any style issues I > >> might find. When you're 100% ready for me to do so, add your changes to > >> github and send me a pull request. Changes to the docs files would be > >> really, really nice to see. User tests for the new functionality would be > >> nice, but I'll do them if you don't have time. > > >> If you need help with git, I can give you some guidance. There's a > >> learning curve there. Email me directly if you want to chat about it or > >> anything else.
