Hi, 

yes, definitely wrong turn, all code should be in CompactPT. 
I am not sure this is actually a code bug, is it working with g++ on
macOS? 

W dniu 2015-10-13 12:50, Jeroen Vermeulen napisaƂ(a): 

> On 10/13/2015 04:59 PM, Hieu Hoang wrote:
> 
>> you're quite right, i've added a check 
>> https://github.com/moses-smt/mosesdecoder/commit/982d52e5b657f4c1fa7369e577cfd75a8af16543
>>  [1] However, that the the problem I'm having on OSX. It opens but it 
>> crashes on loading. I suspect one of the datatypes has slightly different 
>> size on clang/OSX compared to gcc/Linux
> 
> Before the loading gets to this point, CanonicalHuffman.Load() does
> something that intrigues me, as a reader who doesn't really grok the
> code: it fread()s an array of Data.
> 
> If Data is the class I find in mert/Data.h, then AFAICT the compiler
> would be well within its rights to break this. Not only is it not a
> POD, it contains pointers, including in strings and vectors. You
> wouldn't expect that to work. Did I take a wrong turn somewhere?
> 
> Jeroen
> _______________________________________________
> Moses-support mailing list
> Moses-support@mit.edu
> http://mailman.mit.edu/mailman/listinfo/moses-support [2]

 

Links:
------
[1]
https://github.com/moses-smt/mosesdecoder/commit/982d52e5b657f4c1fa7369e577cfd75a8af16543
[2] http://mailman.mit.edu/mailman/listinfo/moses-support
_______________________________________________
Moses-support mailing list
Moses-support@mit.edu
http://mailman.mit.edu/mailman/listinfo/moses-support

Reply via email to