Fair point. It silently ignored unimplemented functionally because moses2
originally implemented only a small subset.

But that subset is getting larger so hopefully there won't be too many
functionality that will cause a throw.

I'll go with your suggestion

Sent while bumping into things

On 3 Nov 2016 10:03 a.m., "Tom Hoar" <tah...@pttools.net> wrote:

Hieu, I'm not sure if it's a good thing for Moses2 to silently ignore
unimplemented params. Wouldn't it avoid a lot of heartache to throw an
error telling which param is not implemented?

On 11/3/2016 2:32 AM, moses-support-requ...@mit.edu wrote:

Date: Wed, 2 Nov 2016 14:32:04 -0500
From: Hieu Hoang <hieuho...@gmail.com> <hieuho...@gmail.com>
Subject: Re: [Moses-support] moses server options different for moses
        vs. moses2
To: Martin Baumg?rtner <martin.baumgaert...@star-group.net>
<martin.baumgaert...@star-group.net>
Cc: "moses-support@mit.edu" <moses-support@mit.edu>
<moses-support@mit.edu> <moses-support@mit.edu>


added:
https://github.com/moses-smt/mosesdecoder/commit/d49170de3dce41b52e4ddacf0b8f82cadb0919ef

it was actually already ported from Moses but the params weren't set up.

Also note that not all the params listed by Moses2 have been
implemented. If they are not implemented, Moses2 will just silently
ignore it.

Will try and make this clearer in the near future



_______________________________________________
Moses-support mailing list
Moses-support@mit.edu
http://mailman.mit.edu/mailman/listinfo/moses-support
_______________________________________________
Moses-support mailing list
Moses-support@mit.edu
http://mailman.mit.edu/mailman/listinfo/moses-support

Reply via email to