In article <[EMAIL PROTECTED]>, Asa Dotzler wrote:
> Chris Hoess wrote:
>
>> To veer off-course a bit, while improving the ease of code contribution is
>> a Good Thing, I'd like to see some additional assurance put in place to
>> help make sure contributed code gets reviewed. I've seen a lot of code
>> rotting in Bugzilla
>
>
> Please post bug numbers. Generalities don't get us anywhere. I don't
> know many people that spend more time in Bugzilla than I do and I don't
> see "a lot of code rotting in Bugzilla".
>
How about 86869, 91073, 91074, and 91439 for starters. These aren't
actually examples of what I was originally thinking of, but they're worth
a look. (Actually, ISTR an earlier proposal [Gerv?] about having some
sort of expedited review process for minor string changes like this, but
AFAIK nothing came of it.)
> because the author didn't know about the review
>> process, or couldn't get r= when he solicited and gave up, etc., and I'm
>> worried that soliciting new contributions may result in a lot of code
>> going the same way.
>
>
> The, soon to be a part of Bugzilla, Request Tracker (partner to the
> Patch Manager) will make this more obvious. I suggest, however, that
> there are not a lot of patches "rotting in Bugzilla". Feel free to prove
> me wrong with a buglist and I'll try to do something about it.
This sounds like it will help, a lot. It would be nice if people could
sweep through bugs in their component with the "review" keyword (+ other
Bugzilla-search-fu), but obviously people don't have time for that, which
is a problem to be fixed in an entirely different domain.
>
> IMO, we should have some sort of periodic sweep
>> (like BugDay perhaps, but monthly), wherein people hunt through bugs with
>> the "patch" keyword (and attach the keyword, if they hit a bug with an
>> attached patch) and ascertain the status of the patch, try to get review
>> moving on it, &etc.
>
>
> I do this regularly. I don't find patches rotting. Perhaps before we
> mobilize a gang of people all doing the same Bugzilla queries you can
> run a query and post a buglist that points to these problems. It
> probably won't take a group of people to get traction on any languishing
> patches and I'll be glad to do that task if you can point me to a
> buglist. My query skillz are decent but I may have missed one or two,
> there certainly aren't more than a few. When people start using Patch
> Manager to obsolete old patches and flag patch review statu this query
> will become a lot easier.
Maybe my perception is just skewed. I'll try trolling for patches in some
of the areas I'm familiar with and tagging them correctly with patch
manager.
--
Chris Hoess
