On Sat, 2014-10-25 at 01:07 +0200, Max Kellermann wrote:
> On 2014/10/18 16:48, Steven Newbury <st...@snewbury.org.uk> wrote:
> > [PATCH v3] Pulseaudio support for other sample formats
> 
> What happens if probing fails?  Previously, that could not happen, 
> but
> now, the probe_formats list can exhaust, and you have no check for 
> it.
> 
I that case the sample spec will have PA_SAMPLE_INVALID as its format 
type, which will cause the stream open to fail*.  This can happen for 
example if the sample rate is out of range for a given format, where 
the pa_sample_spec_valid() will reject the sample spec.

*It's quite normal for an output device open to fail, consider a busy 
ALSA interface.

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Reply via email to