On Thu, May 21, 2015 at 3:13 AM, Max Kellermann <m...@duempel.org> wrote:

> What you described are two ways to approach this problem:
>
> 1) Always do fchmod() (but with a big fat code comment!  And only if
>    building with glibc)
>
> 2) do nothing, and if users complain, tell them to upgrade their buggy
>    C library.  That's not our bug, after all!
>
> I always prefer (2).  MPD uses so many libraries, and if I would add
> workarounds for all old versions of all libraries, MPD would be a huge
> mess.  Many years ago, I decided I wouldn't add any workarounds for
> library bugs, and it turned out bugs really got fixed in those
> libraries, and eventually users upgraded their libraries!  That made
> such problems go away.


No release of glibc has the fix yet. How about (1) + comment to remove
workaround when a version of glibc (probably 2.22) containing the fix is
released?
_______________________________________________
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Reply via email to