The fix works for MinGW64 , and clearly this will have no impact on other
arch's
However we get a futher failure on nehalem-w64-mingw32 of
make[4]: Leaving directory `/c/cygwin/home/root/BOX11/tests/cxx'
make check-TESTS
make[4]: Entering directory `/c/cygwin/home/root/BOX11/tests/cxx'
make[5]: Entering directory `/c/cygwin/home/root/BOX11/tests/cxx'
PASS: t-headers.exe
FAIL: t-binary.exe
FAIL: t-assign.exe
FAIL: t-istream.exe
FAIL: t-constr.exe
FAIL: t-cast.exe
FAIL: t-misc.exe
FAIL: t-locale.exe
FAIL: t-prec.exe
FAIL: t-unary.exe
FAIL: t-ostream.exe
FAIL: t-rand.exe
FAIL: t-ternary.exe
FAIL: t-ops.exe
=============================================================
13 of 14 tests failed
See tests/cxx/test-suite.log
Please report to http://groups.google.co.uk/group/mpir-devel/
=============================================================
make[5]: *** [test-suite.log] Error 1
make[5]: Leaving directory `/c/cygwin/home/root/BOX11/tests/cxx'
make[4]: *** [check-TESTS] Error 2
make[4]: Leaving directory `/c/cygwin/home/root/BOX11/tests/cxx'
make[3]: *** [check-am] Error 2
make[3]: Leaving directory `/c/cygwin/home/root/BOX11/tests/cxx'
make[2]: *** [check-recursive] Error 1
make[2]: Leaving directory `/c/cygwin/home/root/BOX11/tests'
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory `/c/cygwin/home/root/BOX11'
make: *** [check] Error 2
BOX11
PASSED CC=gcc CXX=g++ configure=
PASSED CC=gcc CXX=g++ configure= --enable-cxx --enable-gmpcompat
PASSED CC=gcc CXX=g++
configure= --enable-cxx --enable-gmpcompat --enable-assert
--enable-alloca=debug
PASSED CC=gcc CXX=g++
configure= --enable-cxx --enable-gmpcompat --enable-assert
--enable-alloca=debug --build=none-w64-mingw32
PASSED CC=gcc CXX=g++ configure= --enable-fat
PASSED CC=gcc CXX=g++
configure= --enable-fat --enable-cxx --enable-gmpcompat
PASSED CC=gcc CXX=g++
configure= --enable-fat --enable-cxx --enable-gmpcompat --
enable-assert --enable-alloca=debug
PASSED CC=gcc CXX=g++ configure= --enable-shared --disable-static
FAILED CC=gcc CXX=g++
configure= --enable-shared --disable-static --enable-cxx -
-enable-gmpcompat
The failure occurs with a shared lib with C++ (static lib with C++ is OK) ,
the error is that for some reason it thinks the lib's dont exist
ie we get pop-up windows which say
libmpir-8.dll not found
libmpirxx-2.dll not found
I'll be mostly offline for the next few hours , as I rewire the rats nest of
wires around the house :)
Jason
----- Original Message -----
From: "jason" <ja...@njkfrudils.plus.com>
To: <mpir-devel@googlegroups.com>
Sent: Wednesday, November 10, 2010 9:45 AM
Subject: Re: [mpir-devel] Re: MPIR-2.2.0-rc1 released
Cheers , I'll just exclude it for MinGW64
Thansk
Jason
----- Original Message -----
From: "Cactus" <rieman...@gmail.com>
To: "mpir-devel" <mpir-devel@googlegroups.com>
Sent: Wednesday, November 10, 2010 9:21 AM
Subject: [mpir-devel] Re: MPIR-2.2.0-rc1 released
On Nov 10, 8:38 am, "jason" <ja...@njkfrudils.plus.com> wrote:
The fix that Brian and I did for the locale for C should also work for
C++
as in tests/cxx/clocale.c there is the same over-riding definition of
localeconv , so I think that the same exclusions should apply ie the C
version
#if ! (defined(__MINGW64__) || (defined(_MSC_VER) && _MSC_VER < 1500))
#if HAVE_LOCALECONV
#ifdef _MSC_VER
__GMP_DECLSPEC
#endif
struct lconv *
localeconv (void)
{
static struct lconv l;
l.decimal_point = decimal_point;
return &l;}
#endif
#endif
and the present C++ version
#if HAVE_LOCALECONV
struct lconv *
localeconv (void)
{
static struct lconv l;
l.decimal_point = point_string;
return &l;}
#endif
So if I change the C++ version so it is the same as the C version , then
it
should "pass" the tests.
Brian is this the right fix for MSVC ?
I'll test it on mingw64 now
Jason
----- Original Message -----
From: "jason" <ja...@njkfrudils.plus.com>
To: <mpir-devel@googlegroups.com>
Sent: Wednesday, November 10, 2010 8:18 AM
Subject: Re: [mpir-devel] Re: MPIR-2.2.0-rc1 released
> On nehalem-w64-mingw32
> /lib
> /bin/sh ../../libtool --tag=CXX --mode=link
> g++ -O2 -m64 -march=core2 -mtune=
> core2 -o t-unary.exe t-unary.o -L../../.libs ../../tests/libtests.la
> ../../lib
> mpirxx.la ../../libmpir.la
> c:/mingw/bin/../lib/gcc/x86_64-w64-mingw32/4.6.0/../../../../x86_64-w64-min
> gw32/
> lib/../lib/libmsvcrt.a(dusfs00649.o):(.text+0x0): multiple definition
> of
> `locale
> conv'
> clocale.o:clocale.c:(.text+0x0): first defined here
> collect2: ld returned 1 exit status
> make[4]: *** [t-locale.exe] Error 1
> make[4]: *** Waiting for unfinished jobs....
> libtool: link: g++ -O2 -m64 -march=core2 -mtune=core2 -o
> t-misc.exe -misc.o -L
> /c/cygwin/home/root/BOX11/.libs ../../tests/.libs/libtests.a
> ../../.libs/libmpir
> xx.a
-L/c/bb/vista64-mingw32/mingw-x86-x86_64/build/build/gcc/obj/x86_64-w64-min
> Clearly C++ handles the locale differently than the plain C , because I
> fixed that case , this should be an easy fix I hope , my knowledge of
> C++
> is minimal
> Jason
> --
> You received this message because you are subscribed to the Google
> Groups
> "mpir-devel" group.
> To post to this group, send email to mpir-de...@googlegroups.com.
> To unsubscribe from this group, send email to
> mpir-devel+unsubscr...@googlegroups.com.
> For more options, visit this group at
>http://groups.google.com/group/mpir-devel?hl=en.
Hi Jason,
The MSVC version makes no use of the clocale.c file since locale
replacement just works in C++ 'out of the box' so we don't need to
fake it.
Brian
--
You received this message because you are subscribed to the Google Groups
"mpir-devel" group.
To post to this group, send email to mpir-de...@googlegroups.com.
To unsubscribe from this group, send email to
mpir-devel+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/mpir-devel?hl=en.
--
You received this message because you are subscribed to the Google Groups
"mpir-devel" group.
To post to this group, send email to mpir-de...@googlegroups.com.
To unsubscribe from this group, send email to
mpir-devel+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/mpir-devel?hl=en.
--
You received this message because you are subscribed to the Google Groups
"mpir-devel" group.
To post to this group, send email to mpir-de...@googlegroups.com.
To unsubscribe from this group, send email to
mpir-devel+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/mpir-devel?hl=en.
