On 12 October 2012 22:27, Brian Gladman <b...@gladman.plus.com> wrote: > -----Original Message----- From: Bill Hart > Sent: Friday, October 12, 2012 10:20 PM > > To: mpir-devel@googlegroups.com > Subject: Re: [mpir-devel] MPIR 2.6.0 alpha1 released > > On 12 October 2012 22:13, Brian Gladman <b...@gladman.plus.com> wrote: >> >> -----Original Message----- From: Bill Hart >> Sent: Friday, October 12, 2012 10:05 PM >> >> To: mpir-devel@googlegroups.com >> Subject: Re: [mpir-devel] MPIR 2.6.0 alpha1 released >> >> [snip] >> >>> >>> I have a feeling we need to go back to some underlying principles here. >>> >>> So for a start, intmax_t and uintmax_t on Windows are defined in stdint.h >>> (C) or cstdint (C++) and they can only be used on MSVC10 and later. They >>> can be detected by looking for the stdint.h guard _STDINT which can hence >>> be >>> used to remove code and tests of these types. >> >> >> >> The _STDINT guard is define in stdint.h. So you need to include it >> before you can check if it is available. >> >> ======================================== >> In test code yes but not in mpirxx.h, where we can use >> >> #ifdef _STDINT >> code using uintmax_t and/or uintmax_t >> #endif >> ======================================== > > > But this will always exclude that code unless stdint.h is included > somewhere. So where is it going to be included? It would have to be > included in our test code, which we can't do. > > ============================== > When an MPIR user includes stdint.h or cstdint in _their_ code before they > include mpirxx.h, the types in question will then be available to them > ==============================
OK, but we can't test that this works. > > > It's also a massive burden on the user to test whether stdint.h is > available, and to know to include before mpirxx.h if it is. > > ============================== > If they want to use facilities that _require_ either stdint.h or cstdint, > how is this a burden that they can avoid? > > Yes, you are right about this point. Bill. -- You received this message because you are subscribed to the Google Groups "mpir-devel" group. To post to this group, send email to mpir-devel@googlegroups.com. To unsubscribe from this group, send email to mpir-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/mpir-devel?hl=en.
