[
https://issues.apache.org/jira/browse/MRUNIT-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232187#comment-13232187
]
Jarek Jarcec Cecho commented on MRUNIT-68:
------------------------------------------
* Good point about the compiler error, you could change the name in TestDriver
from withCounter to addCounter and then you wont have the compiler error
I honestly prefer returning this in TestDriver even thought that return value
is not used. It seems to me cleaner and more consistent with the rest of the
code. However please feel free to rename the method.
* One other suggestion is that the expected 0 counter size check is unnecessary
at the beginning of validate, success will remain true and neither for loop
will run if both are 0.
No issues on my side at all. I've put the check there because I was following
previous implementation of validate(expectedOutputs). My intention was just to
be consistent.
> Support custom counter checking
> -------------------------------
>
> Key: MRUNIT-68
> URL: https://issues.apache.org/jira/browse/MRUNIT-68
> Project: MRUnit
> Issue Type: New Feature
> Affects Versions: 0.8.1
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Fix For: 1.0.0
>
> Attachments: MRUNIT-68.patch, MRUNIT-68.patch, MRUNIT-68.patch,
> MRUNIT-68.patch
>
>
> It would be great if user could check custom counter values in addition to
> checking outputs. Let me show my idea on example, right now counters needs to
> be checked explicitly:
> assertEquals(2,
> mapDriver.getCounters().findCounter(CustomMapper.CustomCounter.NAME).getValue());
> It would be great if user could do something like:
> .withCounter(CustomMapper.CustomCounter.Name, 2)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
