[ 
https://issues.apache.org/jira/browse/MRUNIT-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233167#comment-13233167
 ] 

Jim Donofrio commented on MRUNIT-68:
------------------------------------

I removed the unnecessary 0 counter size check in rev 1302763.

I dont understand how it would be consistent with the rest of the code if we 
changed the name to addCounter. All of the other add methods return void. If we 
changed the name to addCounter then it should also return void to be consistent.
                
> Support custom counter checking
> -------------------------------
>
>                 Key: MRUNIT-68
>                 URL: https://issues.apache.org/jira/browse/MRUNIT-68
>             Project: MRUnit
>          Issue Type: New Feature
>    Affects Versions: 0.8.1
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 1.0.0
>
>         Attachments: MRUNIT-68.patch, MRUNIT-68.patch, MRUNIT-68.patch, 
> MRUNIT-68.patch
>
>
> It would be great if user could check custom counter values in addition to 
> checking outputs. Let me show my idea on example, right now counters needs to 
> be checked explicitly:
> assertEquals(2, 
> mapDriver.getCounters().findCounter(CustomMapper.CustomCounter.NAME).getValue());
> It would be great if user could do something like:
> .withCounter(CustomMapper.CustomCounter.Name, 2)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to