I pushed an updated patch to work/install-fewer.

BTW,
"git diff --text" works pretty well to review changes in
ReleaseNotes.rtf.


On Jan 19, 2008, at 11:57 PM, Steffen Prohaska wrote:

On Jan 19, 2008, at 11:42 PM, Johannes Schindelin wrote:

This patch looks good, except that it calls "egrep", which is a simple script to call "grep -E", so I would like the patch to be more explicit and call "grep -E" right away. Or even better: "grep", since it does not
even start to begin using extended regular expressions.

I'll check this.  My first "grep" didn't work.  Maybe I need
'\|' instead of a simple '|'.  I'll find out.

grep '\|' works.


git-mailinfo.exe
git-mailsplit.exe

AFAIR these are needed for git-am.

I'll check.

They are needed.



The last list contains commands that I think should be installed:

git-citool

AFAICT this is not built anymore by git.git.

I ran "rm /bin/git*" and did a fresh install.  I'll check
again.

If it is still built, I'll exclude it from the installer.

It is built by git.git.  It's listed in git-gui/Makefile as

    GITGUI_BUILT_INS = git-citool

I see two options
 - exclude it from msysgit's Git-installer.
 - propose upstream to remove it and wait.

git-citool works and therefore I tend to leave it in the
installer.


git-gui
git-gui.tcl

Do we really need both? Or is the second just a left-over from an old
install?

dunno, will check.

The current implementation needs both.  I propose to leave this
until 1.5.4 is released.  Maybe we should cleanup afterwards?

        Steffen



Reply via email to