Hi, I recompiled mpd and unfortunately those warnings are back again: decoder/aac_plugin.c: In function 'getAacFloatTotalTime': decoder/aac_plugin.c:259: warning: dereferencing type-punned pointer will break strict-aliasing rules decoder/aac_plugin.c: In function 'aac_stream_decode': decoder/aac_plugin.c:323: warning: dereferencing type-punned pointer will break strict-aliasing rules Do you think using unions would be a reasonable solution?
Regards, Kodest On Sun, Nov 16, 2008 at 9:21 PM, Kodest <[EMAIL PROTECTED]> wrote: > Hi, > > Actually, I just checked the faad.h -> neaacdec.h headers to see how > the sample_rate argument was declared in the function prototype. I saw > that was an unsigned long, so I corrected the aac plugin according to. > After that I tested and it worked for me. Maybe it wouldn't work on a > big endian platform if I think into it... I should have investigated > further but thanks for doing that. This aac stuff seems to be > something odd after seeing the wavpack codes. > > Regards, > Kodest > > On Sun, Nov 16, 2008 at 8:34 PM, Max Kellermann <[EMAIL PROTECTED]> wrote: >> On 2008/11/15 12:10, Kodest <[EMAIL PROTECTED]> wrote: >>> aac: fix compiler warnings on amd64 >> >> This patch was actually somewhat incorrect, but you couldn't know that >> unless you looked into the libfaad sources.... see >> >> >> http://git.musicpd.org/cgit/cirrus/mpd.git/commit/?id=9c4e97a61b59105c9b539faca272305bbb234c17 >> >> for an explanation. >> >> Max >> > ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
