Hi Viliam, here are some notes on your archive plugin patches. First, thanks for your work - the archive API will be a very useful addition to MPD.
- your patches introduce a lot of indentation errors and trailing whitespace (enable git colors to view them) - you don't need the NULL sentinel in archive_plugins when you have num_archive_plugins (using G_N_ELEMENTS) - please document archive_lookup(); probably change its return type to "bool" - archive_lookup() should not continue when it has found a non-regular file. - the pathname argument to archive_lookup() should be const; don't write to it! - don't use xstrdup() / xfree() etc. - they are deprecated, in favor of GLib - input_archive_open() calls the archive_plugin->open() method _again_ - this disallows caching - don't mess around with input_stream->plugin; this looks quite hackish - do not import external libraries like minizip/unrarlib; rather find a shared/static library to link with - "archiveapi: adding archive api plugin as first for lookup (before file inputstream)": explain why you are doing this - "archiveapi: hasArchiveSuffix() function introduces", "archiveapi: string lookup funtion used by decoder and archives": no new code with CamelCase, please - "archiveapi: adding flag used by update to differ archive and file when adding song" the patch description is bogus - "archiveapi: rewritten update routine to support in archive songs": just pass 0 to hasMusicSuffix(); remove that bogus "next" variable. - "archiveapi: string lookup funtion used by decoder and archives": this patch itself is unrelated to "archiveapi"; replace "archiveapi:" with "utils:" - "archiveapi: configure scripts": each patch should bring its own configure.ac changes - I cannot compile any of these patches unless all of them are applied at the same time. Please do not write patches which don't work by themselves. You cannot use a function which you havn't already added (e.g. stringFoundInStringArray()), and you cannot rely on autoconf variables which are added in a patch which comes later. Seeking to any commit should produce a fully working MPD. Max ------------------------------------------------------------------------------ SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada. The future of the web can't happen without you. Join us at MIX09 to help pave the way to the Next Web now. Learn more and register at http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/ _______________________________________________ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
