Hi Viliam, good work! I have just read your current experimental branch (commit afb0acc3), it looks really good now.
There is one thing I don't like currently: you added the "archive" pointer to the input_stream struct. That adds archive specific stuff to the generic input_stream API. I think we will find a better solution for that later. The archive_plugin_init_all() / archive_plugin_deinit_all() calls are currently added by the patch "main: printout of archive plugins compiled in" - that belongs to the previous patch (I can be very picky, you see? ;)) Patch "song: adding support for songs in archives" introduces another hack: it adds the special "device" number DEVICE_INARCHIVE. Since tag reading support isn't implemented yet (due to shortcomings in the decoder API), we will use that anyway, for now. The configure option "--enable-iso" should probably be renamed to "--enable-iso9660". You're checking for those libraries even when the user has disabled them (--disable-zip etc.) - that consumes a lot of time. Still lots of whitespace errors: lots of lines indented with spaces instead of tabs. Please fix those "unused parameter" warnings (use G_GNUC_UNUSED if you really don't need these). Always configure with "--enable-werror" to be sure you don't miss a warning. As soon as you fix the warnings and the indentation, I'll merge your patches into experimental. Let's hope we get MPD 0.14 out in a few days, then the archive API can enter the master branch (0.15~git then). Max ------------------------------------------------------------------------------ SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada. The future of the web can't happen without you. Join us at MIX09 to help pave the way to the Next Web now. Learn more and register at http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/ _______________________________________________ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
