On Thu, Mar 5, 2009 at 9:53 PM, Max Kellermann <m...@duempel.org> wrote:
> On 2009/03/06 01:49, Avuton Olrich <avu...@gmail.com> wrote:
>> echo ""
>> -echo " Other features:"
>> +echo " Streaming support:"
>> +
>> +if test x$enable_lame = xyes; then
>> + echo " lame support (mp3 output) .....enabled"
>> +else
>> + echo " lame support (mp3 output) .....disabled"
>> +fi
>
> I'm not quite satisfied with this. The last patch is an overall
> improvement, but I don't see why LAME support should appear twice. We
> should probably write only one "shout" line, and create a new section
> for "encoder plugins" (lame + vorbis). Can you do that, please?
>
> All patches except "more complete autoconf stuff for lastfm" merged.
Well, that was not intentional. Not exactly what you asked for, but
hopefully this will float the boat.
Avuton Olrich (2):
configure: make all tests the same, when possible.
configure: remove duplicate LAME report, unify rest under
SHOUTcast header.
configure.ac | 32 ++++++++++++++++----------------
1 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/configure.ac b/configure.ac
index a3d929b..0bc29a4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1271,16 +1271,22 @@ else
echo " Media MVP support .............disabled"
fi
-if test x$enable_shout_ogg = xyes; then
- echo " Shout ogg streaming support ...enabled"
-else
- echo " Shout ogg streaming support ...disabled"
-fi
+if test x$enable_shout = xyes; then
+ echo " SHOUTcast support .............enabled"
-if test x$enable_shout_mp3 = xyes; then
- echo " Shout mp3 streaming support ...enabled"
+ if test x$enable_shout_mp3 = xyes; then
+ echo " with LAME mp3 encoder .......enabled"
+ else
+ echo " with LAME mp3 encoder .......disabled"
+ fi
+
+ if test x$enable_shout_ogg = xyes; then
+ echo " with Ogg Vorbis encoder .....enabled"
+ else
+ echo " with Ogg Vorbis encoder .....disabled"
+ fi
else
- echo " Shout mp3 streaming support ...disabled"
+ echo " SHOUTcast support .............disabled"
fi
echo ""
@@ -1447,25 +1453,19 @@ fi
echo ""
echo " Streaming support:"
-if test x$enable_lame = xyes; then
- echo " lame support (mp3 output) .....enabled"
-else
- echo " lame support (mp3 output) .....disabled"
-fi
-
if test x$enable_lastfm = xyes; then
echo " last.fm radio support .........enabled"
else
echo " last.fm radio support .........disabled"
fi
-if test x$enable_curl != xno; then
+if test x$enable_curl = xyes; then
echo " libcurl support (streaming) ...enabled"
else
echo " libcurl support (streaming) ...disabled"
fi
-if test x$enable_mms != xno; then
+if test x$enable_mms = xyes; then
echo " libmms support ................enabled"
else
echo " libmms support ................disabled"
--
avuton
--
| (\_/) This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.
------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
