On 2009/03/06 18:21, David Guibert <david.guib...@gmail.com> wrote: > This patch introduces the mixer for the pulse output.
Thanks, I have merged that patch. I removed the daemonization changes in main.c. Please explain why you changed that. If you need it for some reason, make that a separate patch with a good description of your rationale. The NULL pointer dereference which Avuton found was in fact a bug in the mixer API, following your plugin's failure to initialize. That's the biggest flaw of your code: it opens the mixer device in the init() method, while the open() method is empty. When the pulse daemon is not available (either during MPD startup or when it dies while MPD runs), the plugin will not even attempt to reconnect to pulse. Please move the code to the open() method, to make that work. Max ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
