Hi -
I found a bug which is somewhat similar but only leads
to annoying "decoder uninitialized" messages:
In flac_container_decode(), if the playtime of the track
is over, flac_finish() is called. The loop is then left,
and flacPrintErroredState(flac_get_state(flac_dec))
is called which leads to that message. (flac_finish()
is called a second time which is appearently harmless.)
Perhaps the logics should get some cleanup -- my patch
just works around this but doesn't make the code
any nicer.
best regards
Matthias



------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------
Forschungszentrum Juelich GmbH
52425 Juelich
Sitz der Gesellschaft: Juelich
Eingetragen im Handelsregister des Amtsgerichts Dueren Nr. HR B 3498
Vorsitzende des Aufsichtsrats: MinDir'in Baerbel Brumme-Bothe
Geschaeftsfuehrung: Prof. Dr. Achim Bachem (Vorsitzender),
Dr. Ulrich Krafft (stellv. Vorsitzender), Prof. Dr.-Ing. Harald Bolt,
Prof. Dr. Sebastian M. Schmidt
------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------
$NetBSD: patch-aa,v 1.9 2009/07/30 16:51:04 drochner Exp $

--- src/decoder/flac_plugin.c.orig      2009-07-15 22:34:47.000000000 +0200
+++ src/decoder/flac_plugin.c
@@ -619,6 +619,7 @@ flac_container_decode(struct decoder* de
                // we only need to break at the end of track if we are in "cue 
mode"
                if (data.time >= data.total_time)
                {
+                       break;
                        flacPrintErroredState(flac_get_state(flac_dec));
                        flac_finish(flac_dec);
                }
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team

Reply via email to