oh, Game Music Emu libraries, need to try it. 2009/11/2, Max Kellermann <m...@duempel.org>: > On 2009/11/02 03:37, kernel error <k3rn3l.3r...@gmail.com> wrote: >> I suggest you a new plugin decoder which is able to read vtx >> "chiptune" format (Zx Spectrum music format). I used libayemu >> (http://sashnov.nm.ru/libayemu.html), it was released under GPLv2, so >> I suppose its compatible with your current license. >> Decoder plugin and patch can be found here: >> http://git.tuxfamily.org/kernelblog/vtxplugin.git >> >> As well, I checked some possible errors through valgrind, it founds 3 >> errors directly from libayemu but nothing in my code. > > Your code looks good, but I don't understand the complicated SNDNEED > loop. What's the point of that? Please add some source comments > explaining that. Technically, SNDNEED = SNDBUF/(channels*(bits/8)), i assume that mean the number of instructions to execute ? but I'm really not sure, I take xmms-plugin as an example and I confess I don't understood completly his working.
> Please add the library dependency to the INSTALL file. > > Your patch misses the required Makefile.am and configure.ac change. Well, I never used autotools, always cmake or written my own Makefile, so I'll try something "clean" but I promise nothing. > And what's your real name, by the way? We use real names for commits > in our git repository. > > You're using git in a funny way. Why not clone our master repository, > and create one commit for your plugin? This way, we could just pull > your patch with one command. Thats a great idea :) > Max > > -- Regards, kernel_error ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
