Because I missed it when I read the man-page (normally, you would put the documentation for environment variables in a separate section, see the main git man page, for example).
When I went looking in the source, I didn't find any getenv() calls, but, of course, that is handled in libmpdclient code, and I failed to look there. I added MPC_FORMAT for completeness, but I don't see a real use for it. So ignore my patch (I've deleted the repo from my server). I'll come back when I've added something useful. Jeff On Mon, 4 Jan 2010, Max Kellermann wrote: > On 2010/01/04 22:51, Jeff Frasca <phaed...@u.washington.edu> wrote: >> I put a git repo on my server and pushed the changes there, you can grab >> it with: >> >> git pull http://sasquatch-labs.org/git/mpc.git master >> >> It adds support for the environment variables 'MPC_HOST', 'MPC_PORT', >> 'MPC_FORMAT' and 'MPC_PASSWD'. They set the same settings as the >> -h, -p, -f and -P options. They are read before option parsing, so >> anything specified on the command line overrides the environment. > > mpc already supports MPD_HOST and MPD_PORT, and you can specify a > password in MPD_HOST. > > What remains in your patch is the MPC_FORMAT variable, but what is the > point of that? > ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
