On 2012/02/28 20:27, Robert Vollmert <rvollmert-li...@gmx.net> wrote:
> Hello,
> 
> I've long wanted to play soundcloud tracks through my MPD setup, and found 
> some discussion in the archives that suggested doing this using a playlist 
> plugin. I've implemented that, patch attached. If you'd like, I can push it 
> to git.musicpd.org if you create an account for me.
> 
> Re the patch, I'm not an experienced C coder, a lot of this is copying how 
> other people do things, so I may well have missed something. It seems to work 
> for me. Also, this uses YAJL for JSON and I didn't know how to make autoconf 
> handle that. Let me know if you'd like to see something done differently, 
> style or otherwise.

Please fix those compiler warnings:

src/playlist/soundcloud_playlist_plugin.c:218:2: error: initialization from 
incompatible pointer type
src/playlist/soundcloud_playlist_plugin.c:218:2: error: (near initialization 
for 'parse_callbacks.yajl_string')
src/playlist/soundcloud_playlist_plugin.c:220:2: error: initialization from 
incompatible pointer type
src/playlist/soundcloud_playlist_plugin.c:220:2: error: (near initialization 
for 'parse_callbacks.yajl_map_key')
src/playlist/soundcloud_playlist_plugin.c: In function 'soundcloud_parse_json':
src/playlist/soundcloud_playlist_plugin.c:240:2: error: implicit declaration of 
function 'input_stream_open' [-Wimplicit-function-declaration]
src/playlist/soundcloud_playlist_plugin.c:240:15: error: assignment makes 
pointer from integer without a cast
src/playlist/soundcloud_playlist_plugin.c:246:3: error: return makes integer 
from pointer without a cast
src/playlist/soundcloud_playlist_plugin.c:250:2: error: implicit declaration of 
function 'input_stream_wait_ready' [-Wimplicit-function-declaration]
src/playlist/soundcloud_playlist_plugin.c:256:3: error: implicit declaration of 
function 'input_stream_read' [-Wimplicit-function-declaration]
src/playlist/soundcloud_playlist_plugin.c:262:4: error: implicit declaration of 
function 'input_stream_eof' [-Wimplicit-function-declaration]
src/playlist/soundcloud_playlist_plugin.c:266:5: error: implicit declaration of 
function 'input_stream_close' [-Wimplicit-function-declaration]
src/playlist/soundcloud_playlist_plugin.c:274:4: error: pointer targets in 
passing argument 2 of 'yajl_parse' differ in signedness [-Wpointer-sign]
/usr/include/yajl/yajl_parse.h:143:26: note: expected 'const unsigned char *' 
but argument is of type 'char *'
src/playlist/soundcloud_playlist_plugin.c:279:4: error: pointer targets in 
passing argument 3 of 'yajl_get_error' differ in signedness [-Wpointer-sign]
/usr/include/yajl/yajl_parse.h:168:30: note: expected 'const unsigned char *' 
but argument is of type 'char *'

------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team

Reply via email to