On Mon, 2012-04-23 at 19:09 +0200, Max Kellermann wrote: > On 2012/04/21 13:29, Jurgen Kramer <gtmkra...@xs4all.nl> wrote: > > - Adhered to max 80 colom width > > This is not doxygen syntax, and is barely readable. Please use > doxygen syntax for documenting struct attributes. > > > - Fixed indents (hopefully correctly) > > What did you fix? Indentation dsdiff_read_metadata() is still all > wrong. > > > I took a stab a changing the loop part. Please check, it probably needs > > some more work. > > I don't see what you changed. > > There are 17 whitespace errors in your patch according to git. > Please show me how I can check myself. It is getting a bit tiresome to hear about wrong tabs/indents.
Jurgen ------------------------------------------------------------------------------ For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! http://p.sf.net/sfu/Boundary-d2dvs2 _______________________________________________ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
