On 11/22/12 at 12:48am, Federico Bruni wrote: > Il 21/11/2012 22:34, Felix Janda ha scritto: > >> We should use git and possibly github pull requests to avoid duplication > >> > of work. > >> > I've started from a simple piece just to see what it will go on: > >> > https://github.com/chrissawer/The-Mutopia-Project/pulls > > I pulled in your changes and compared it to the original piece. It looks > > very nice and you even went to make the midi file more accurate. Do you know > > where the "N.C." above the upbeat comes from? > > > > It stands for "No Chord". > If you use s instead of r, it's removed. > I guess that it would be better... but I'm not a notation expert
Shouldn't be of great importance. I just noticed it when comparing the output. Another thing: The "copyright" header field is missing. > > I forgot to mention: My fork is at > > https://github.com/doughdemon/The-Mutopia-Project.git > > and I would be happy about some review. It's not of that high quality of > > yours > > but updates a lot of the version 1.* pieces. I'm also by no means an expert. > > (And I feel that removing #(ly:set-option 'old-relative) is very > > dangerous...) > > Wow, you've done a lot. > The problem is that your updates are not public visible. Maybe someone > else has worked on some of those files and noone is aware of it: this > waste of time and resources would be a shame. I consider having a public fork on github kind of public... I likely should have added a pull request some time ago to make it more visible. It seemed to me the only active fork until you stepped up, though. > Let's wait for the new admin team to setup a new way to review > contributions, then I'll be glad to review some of your files. The new admin team must first come into its existence. (If you want to try something out just configure a remote, pull the changes into a new branch and cherry-pick one commit at a time into yet another branch. (There might be a better method.)) Waiting for the developments seems sensible. > Ciao > -- > Federico _______________________________________________ Mutopia-discuss mailing list [email protected] http://lists.bcn.mythic-beasts.com/mailman/listinfo/mutopia-discuss
