#3638: Compilation errors for 1.6
----------------------+----------------------
Reporter: grarpamp | Owner: mutt-dev
Type: defect | Status: new
Priority: major | Milestone: 1.6
Component: mutt | Version: 1.5.21
Keywords: |
----------------------+----------------------
FreeBSD 8.3 i386
mutt 1.5.21 hg (today's daily)
Here are all the compile errors on the above with hg to look through for
upcoming 1.6 release...
imap.c:283: warning: dereferencing type-punned pointer will break strict-
aliasing rules
imap.c:1355: warning: dereferencing type-punned pointer will break strict-
aliasing rules
message.c:63: warning: unused variable 'buf'
main.c:75: warning: string length '558' is greater than the length '509'
ISO C90 compilers are required to support
ascii.h:35: warning: 'ascii_tolower' declared inline after being called
ascii.h:35: warning: previous declaration of 'ascii_tolower' was here
pop_lib.c:67: warning: implicit declaration of function 'ntohs'
lib.c:569: warning: warning: mktemp() possibly used unsafely; consider
using mkstemp()
byteorder(3) says ntohs is in either:
#include <arpa/inet.h>
#include <netinet/in.h>
mkstemp(3) actually creates the file returning fd, thus securing against
races.
I'd consider having configure test for it and implementing it in
muttlib.c.
I also get this difference when using LDFLAGS=-static ...
< checking for idna_to_unicode_8z8z... yes
> checking for idna_to_unicode_8z8z... no
< checking for idna_to_ascii_8z... yes
< checking for idna_to_ascii_lz... yes
> checking for idna_to_ascii_8z... no
> checking for idna_to_ascii_lz... no
I can pull and retest as needed. Thanks.
--
Ticket URL: <http://dev.mutt.org/trac/ticket/3638>
Mutt <http://www.mutt.org/>
The Mutt mail user agent
