#3644: segmentation fault when viewing an application/x-sh attachment
-----------------------+----------------------
Reporter: vinc17 | Owner: me
Type: defect | Status: assigned
Priority: critical | Milestone:
Component: mutt | Version:
Resolution: | Keywords:
-----------------------+----------------------
Changes (by me):
* owner: mutt-dev => me
* status: new => assigned
Comment:
Replying to [comment:2 kevin8t8]:
> This looks like it was introduced by changeset b9f9e3147eb4.
>
> It's not clear to me whether we should be calling
mutt_decode_attachment() for the compose/send case. Would it make sense
to revert back to calling mutt_save_attachment() when fp == NULL (for the
use_pager/text case)? Hopefully one of the core devs can chime in.
I think this is the correct idea. At first I thought maybe we should set
decode_state.fpin temporarily from a->filename, but I realized that
mutt_decode_attachment() expects that the content-transfer-encoding has
been applied, and that is not true in this case.
I just reformatted your simple.patch to be consistent to how we do checks
for:
{{{
if (fp == NULL)
}}}
elsewhere.
--
Ticket URL: <http://dev.mutt.org/trac/ticket/3644#comment:3>
Mutt <http://www.mutt.org/>
The Mutt mail user agent
